Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sounds don't get correctly applied when loading a savestate #142

Closed
ScribbleTAS opened this issue May 15, 2022 · 1 comment
Closed

Sounds don't get correctly applied when loading a savestate #142

ScribbleTAS opened this issue May 15, 2022 · 1 comment
Labels
Bug Something isn't working Savestates Issue is related to savestates

Comments

@ScribbleTAS
Copy link
Member

No description provided.

@ScribbleTAS ScribbleTAS changed the title Sounds don't stop after loading a savestateq Sounds don't stop after loading a savestate May 15, 2022
@ScribbleTAS ScribbleTAS added Savestates Issue is related to savestates Bug Something isn't working labels May 15, 2022
@ScribbleTAS ScribbleTAS changed the title Sounds don't stop after loading a savestate Sounds don't get correctly applied when loading a savestate May 15, 2022
@ScribbleTAS ScribbleTAS mentioned this issue Jul 13, 2024
Draft
@ScribbleTAS ScribbleTAS linked a pull request Jul 13, 2024 that will close this issue
Savestate fixes #214
Draft
@ScribbleTAS
Copy link
Member Author

This seems like an issue that is very unnecessary for our use case... It seems like Minecrafts Sound Engine has no way of setting the correct position and since this only applies to savestates, just playing back the movie in full will give you the correct results... Not implementing, unless someone wants to work on this

@ScribbleTAS ScribbleTAS closed this as not planned Won't fix, can't repro, duplicate, stale Aug 13, 2024
@ScribbleTAS ScribbleTAS removed a link to a pull request Aug 13, 2024
Savestate fixes #214
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Savestates Issue is related to savestates
Projects
TASmod
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ScribbleTAS