Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring basic support for AWS China #1564

Closed
2 tasks
LKI opened this issue Jul 13, 2018 · 8 comments
Closed
2 tasks

Bring basic support for AWS China #1564

LKI opened this issue Jul 13, 2018 · 8 comments

Comments

@LKI
Copy link

LKI commented Jul 13, 2018

Context

I've tried to setup zappa in AWS China, and noticed that we lacked support for AWS China.

I want to know if someone is working on it?

If currently there is nobody working on it, may I work on some PR to bring basic supports for AWS China.

Expected Behavior

AWS China is isolated from AWS Global, there are only two regions in AWS China (cn-north-1/cn-northwest-1)
We may have these functionality for basic support:

  • a clear 5-minutes demo
  • some document about the region differences

Actual Behavior

Currently it's not possible to deploy zappa on AWS China if not customizing zappa.

Possible Fix

Main obstacles are:

More

Welcome to leave any comment under this issue.

@ArnoldGitHub
Copy link

ArnoldGitHub commented Jul 14, 2018 via email

@LKI
Copy link
Author

LKI commented Jul 14, 2018

Hi @ArnoldGitHub ,

It's true that CloudFront is unavailable in AWS China, we use other CDN alternatives (qiniu).
So I plan to disable these absent AWS modules during zappa deploy. (CloudFront, Route53, etc...)

Currently I'm trying to deploy to AWS China by customizing zappa.
After that, I may submit some PRs, and it's very nice to have you review/re-test the code.

Thanks~

@staneslevski
Copy link

Hi @LKI

Did you make any progress on this? I'm currently finding the same problem because zappa is not suitable for AWS China.

Thanks.

@LKI
Copy link
Author

LKI commented Jan 26, 2019

Hi @staneslevski ,

I didn't work on this issue now.
We choose self-hosted k8s cluster for better control (which cost more).

More outdated information which may helps:
I successfully deployed zappa to AWS China after I made these changes:

  • Disable Route53/ACM/EnvironmentVariables
  • Adjust arn names the same way as us-gov-west-1
  • Pass ICP Recordal by submitting a case

Thanks.

@LKI LKI closed this as completed Jan 26, 2019
@staneslevski
Copy link

staneslevski commented Jan 27, 2019 via email

@ghost
Copy link

ghost commented Aug 27, 2019

@LKI When you suggest Disable Route53/ACM/EnvironmentVariables, exactly how did you go about doing this? As I get the error EnvironmentVariablesFeature is not supported in cn-northwest-1 region

@LKI
Copy link
Author

LKI commented Aug 27, 2019

@SaErn I fork the repo and add some if statements. You can search us-gov in source codes, and modify in same logic.

one of the Environment Variables modify point: core.py

one of the us-gov if statement: core.py

@linjungz
Copy link

Hi @LKI , I'm also trying to deploy Zappa for AWS China region and thanks for your sharing of the modification. As Route53/ACM/EnvironmentVariables are all available now, is it possible that you could re-open this issue so that we could move on to make Zappa support China region? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants