Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashing consecutive items with plugins is corrupted #20

Open
ankostis opened this issue Dec 16, 2016 · 2 comments
Open

Hashing consecutive items with plugins is corrupted #20

ankostis opened this issue Dec 16, 2016 · 2 comments
Labels

Comments

@ankostis
Copy link
Collaborator

ankostis commented Dec 16, 2016

Currently plugins install digester-instances when initialized.
The SAME-DIGESTERSs are re-used multiple times, corrupting hashes for all but the 1st input!

But in reality, nobody could have discovered this because plugins simply DID NOT WORK :-)

These bug existed since plugins were originally introduced(#9) so the culprit falls completely on me!
And it has not been discovered because TravisCI were not checking them.

To deal with these:

  • I have already started installing TCs, and
  • fixing the plugins (ankostis/omnihash@a21bf38)
  • in order to provide a PR for the corruption bug.
@ankostis ankostis added the bug label Dec 16, 2016
@ankostis
Copy link
Collaborator Author

ankostis commented Dec 16, 2016

See this build for the problem: [edit] https://travis-ci.org/ankostis/omnihash/builds/184589768

Also see this for why when trying to work across PY-versions is easier if not shadowing package-name with module, and using relative imports instead:
https://travis-ci.org/ankostis/omnihash/jobs/184589769

@Miserlou
Copy link
Owner

Eagerly awaiting your PR..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants