Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API Key authentification method #117

Closed
richfab opened this issue Jul 12, 2023 · 4 comments · Fixed by #118
Closed

Add API Key authentification method #117

richfab opened this issue Jul 12, 2023 · 4 comments · Fixed by #118
Assignees

Comments

@richfab
Copy link
Contributor

richfab commented Jul 12, 2023

Some private feeds require an API Key to be fetched.
It would be useful to add the API Key authentification method to validate such feeds.

Before After
image image
@richfab richfab self-assigned this Jul 12, 2023
@testower
Copy link
Collaborator

What exactly does «API Key» mean in this context?

@richfab
Copy link
Contributor Author

richfab commented Jul 12, 2023

What exactly does «API Key» mean in this context?

I was thinking API Key in the context of a unique identifier used to authenticate the client to the server. The API Key is passed in the request header, such as X-API-KEY: key. Thoughts?

@richfab richfab linked a pull request Jul 12, 2023 that will close this issue
@testower
Copy link
Collaborator

testower commented Jul 12, 2023

I think the header name should be configurable, since “x-api-key” is non-standard, and it may vary what people use in the field.

@richfab
Copy link
Contributor Author

richfab commented Jul 12, 2023

I think the header name should be configurable, since “x-api-key” is non-standard, and it may vary what people use in the field.

Good point. I made the header name configurable. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants