From 869af40f4a41c6b53d34a80ffb6119b3d76e0ccf Mon Sep 17 00:00:00 2001 From: Alessandro Kreslin Date: Thu, 4 Apr 2024 10:59:55 -0400 Subject: [PATCH] Error count on missing required files --- gbfs-validator/gbfs.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/gbfs-validator/gbfs.js b/gbfs-validator/gbfs.js index c538cad..71327fe 100644 --- a/gbfs-validator/gbfs.js +++ b/gbfs-validator/gbfs.js @@ -48,6 +48,9 @@ function filesHaveErrors(files) { */ function fileHasErrors(fileData, required) { if (fileHasMultiLanguages(fileData)) { + if(fileData.length === 0 && required) { + return true; + } return fileData.some((languageBody) => hasErrors(languageBody, required)) } // So it's not a multi-language array, just check the data directly. @@ -61,7 +64,7 @@ function fileHasErrors(fileData, required) { * @returns {boolean} */ function hasErrors(fileData, required) { - if (required && !fileData.exists) { + if (required && (!fileData || !fileData.exists)) { return true } if (!!fileData.errors || fileData.hasErrors) { @@ -88,6 +91,10 @@ function fileHasMultiLanguages(fileData) { function countErrors(file) { let count = 0 + if(file.required && !file.exists) { + count++; + } + if (file.hasErrors) { if (file.errors) { count = file.errors.length