Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vehicle_type_id description in station_status #526

Closed
1 of 3 tasks
richfab opened this issue Aug 2, 2023 · 0 comments · Fixed by #527
Closed
1 of 3 tasks

Update vehicle_type_id description in station_status #526

richfab opened this issue Aug 2, 2023 · 0 comments · Fixed by #527
Assignees

Comments

@richfab
Copy link
Contributor

richfab commented Aug 2, 2023

What is the issue and why is it an issue?

In this Slack thread, @hbruch and @testower, pointed out that the description for vehicle_type_id in station_status.json is misleading.

vehicle_type_id: The vehicle_type_id of each vehicle type at the station as described in vehicle_types.json. This field is REQUIRED if the vehicle_types.json is defined.

Possible interpretation: all vehicle types described in vehicle_types.json must be listed, including those with count=0.

This is an issue because producers with many different vehicle_types, wish they would not need to specify every single vehicle type not available at every station, but rather take a not listed vehicle_type_id as count=0 (which is already the current intention of the specs).

Please describe some potential solutions you have considered (even if they aren’t related to GBFS).

Update the vehicle_type_id description in station_status.json:

vehicle_type_id: The vehicle_type_id of each vehicle type at the station as described in vehicle_types.json. A vehicle type not available at the station can be omitted from the list or specified with a count=0.

Note that the JSON-Schema and gbfs-validator have been updated (PR MobilityData/gbfs-json-schema#94 and PR MobilityData/gbfs-validator#124) to reflect this change.

Is your potential solution a breaking change?

  • Yes
  • No
  • Unsure

This change is editorial (it does not modify the behaviour of the specs). So a vote is not required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant