Fix requirement of lat/lon for virtual stations #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does your proposal solve?
Fixes #719
The
is_virtual_stationfield indicates thatlat/lonare OPTIONAL when thestation_areafield is defined.It causes an inconsistency with
lat/lonfields in the same file which are REQUIRED values.What is the proposal?
Remove
lat/lonOPTIONAL inis_virtual_stationfield.Is this a breaking change?
There is no vote needed since this is a clarification of the spec, not a change to a field.
Which files are affected by this change?
station_information.json
Note that the JSON schemas are not affected by the inconsistency. Which means they don't need to be updated and neither do the validator and the models since they are based on the JSON schemas.
Thank you @Yaronn44 for raising this issue 🙏