Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptance tests fail for PR opened from forked repository #1094

Closed
barbeau opened this issue Feb 1, 2022 · 1 comment · Fixed by #1102
Closed

Acceptance tests fail for PR opened from forked repository #1094

barbeau opened this issue Feb 1, 2022 · 1 comment · Fixed by #1102
Labels
bug Something isn't working (crash, a rule has a problem)

Comments

@barbeau
Copy link
Member

barbeau commented Feb 1, 2022

Describe the bug
The acceptance tests implemented in #848 are important because they detect changes to validation output on all datasets in the MobilityDatabase based on changes to validation rule logic.

However, as seen in #1090 (review), these tests fail to execute for forks of the gtfs-validator repo (i.e., all external contributions to the project):

For information Rule acceptance tests fails because the PR merges code from another github repository that does not have access to the credentials required to set up and authorize the usage GCP.

How we reproduce the bug
Steps to reproduce the behaviour:

  1. Fork the gtfs-validator
  2. Change code and open a PR

Expected behaviour
Acceptance tests should complete with a report on changes in validation output for MobilityData datasets as seen in #1083 (comment).

Observed behaviour
It appears the reports can't be persisted to Google Cloud storage because of permissions issues on the credentials, causing the process to fail.

Screenshots:
See #1090 (review)

Environment versions

  • validator version: Master branch as of d797a13
  • Java version: GitHub Action (see master branch)
  • OS versions: GitHub Action (see master branch)
@barbeau barbeau added the bug Something isn't working (crash, a rule has a problem) label Feb 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2022

Thank you for your reporting a bug. The issue has been placed in triage, the MobilityData team will follow-up on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working (crash, a rule has a problem)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants