Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor desktop validation app to call validation code directly instead of cli.Main #1135

Closed
bdferris-v2 opened this issue May 4, 2022 · 0 comments · Fixed by #1145
Closed

Refactor desktop validation app to call validation code directly instead of cli.Main #1135

bdferris-v2 opened this issue May 4, 2022 · 0 comments · Fixed by #1145
Assignees
@bdferris-v2
Labels
enhancement New feature request or improvement on an existing feature
Milestone
v3.1.0 - Result U...

Comments

@bdferris-v2
Copy link
Collaborator

bdferris-v2 commented May 4, 2022 •
edited
Loading

Per #1125, the initial version of our packaged executable is a simple wrapper around cli.Main. This issue tracks the follow up work necessary to call validation code directly, with possible refactoring necessary in the main module. See more detailed design in https://bit.ly/gtfs-validator-packaged-exe.

Two specific feature requests:

  • Better naming of output report file name (include data + feed name where possible).
  • Display of system_errors.json if validation failed with system errors.
@bdferris-v2 bdferris-v2 added the enhancement New feature request or improvement on an existing feature label May 4, 2022
@bdferris-v2 bdferris-v2 self-assigned this May 4, 2022
@bdferris-v2 bdferris-v2 mentioned this issue May 4, 2022
Merged
bdferris-v2 pushed a commit to bdferris-v2/gtfs-validator that referenced this issue May 12, 2022
@bdferris
Refactor cli.Main into ValidationRunner for easier reuse.
1ae8762 
Per discussion in issue MobilityData#1135 and https://bit.ly/gtfs-validator-packaged-exe#heading=h.fcbgc2jy8dh,
we'd like to refactor code in cli.Main into a new class that's easier to call from other contexts,
including the new GUI-based app.
bdferris-v2 pushed a commit to bdferris-v2/gtfs-validator that referenced this issue May 12, 2022
@bdferris
Refactor cli.Main into ValidationRunner for easier reuse.
4d6f1e9 
Per discussion in issue MobilityData#1135 and https://bit.ly/gtfs-validator-packaged-exe#heading=h.fcbgc2jy8dh,
we'd like to refactor code in cli.Main into a new class that's easier to call from other contexts,
including the new GUI-based app.
@bdferris-v2 bdferris-v2 mentioned this issue May 12, 2022
Merged
@bdferris-v2 bdferris-v2 linked a pull request May 12, 2022 that will close this issue
feat: Refactor cli.Main into ValidationRunner for easier reuse. #1145
Merged
maximearmstrong pushed a commit that referenced this issue May 13, 2022
@bdferris-v2 @bdferris
feat: Refactor cli.Main into ValidationRunner for easier reuse. (#1145)
5ad1d78 
* Refactor cli.Main into ValidationRunner for easier reuse.

Per discussion in issue #1135 and https://bit.ly/gtfs-validator-packaged-exe#heading=h.fcbgc2jy8dh,
we'd like to refactor code in cli.Main into a new class that's easier to call from other contexts,
including the new GUI-based app.

* Differntiate between system errors and unrecoverable exceptions in the ValidationRunner return status.  Use that info in the gui app to show the system_errors.json file when appropriate.

* Fix import for javax.swing.JOptionPane.

* Inline `createGson` method.

* Fix ArgumentsTest to work on all platforms (including Windows).

Co-authored-by: Brian Ferris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdferris-v2 bdferris-v2

Labels
enhancement New feature request or improvement on an existing feature
Projects
None yet
Milestone
v3.1.0 - Result UI + Validator as Pac...
Development

Successfully merging a pull request may close this issue.

feat: Refactor cli.Main into ValidationRunner for easier reuse. bdferris-v2/gtfs-validator
1 participant
@bdferris-v2