Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groupType expansion needs full testing with devices. #306

Open
adcxyz opened this issue Jul 6, 2017 · 3 comments
Open

groupType expansion needs full testing with devices. #306

adcxyz opened this issue Jul 6, 2017 · 3 comments

Comments

@adcxyz
Copy link
Contributor

adcxyz commented Jul 6, 2017

ATM groupTypes like noteOnOff, noteOnOffTouch expand properly into MKtlElements,
but not yet into proper responders and midi lookup dict entries within MIDI devices.
-> Do extensive tests of all types and their expansion.

@adcxyz
Copy link
Contributor Author

adcxyz commented Jul 7, 2017

expansion works now with 97e01f3, gui style does not propagate down correctly yet.
still needs full test suite.

@LFSaw
Copy link
Member

LFSaw commented Jul 12, 2017

GUI looks like a new issue to me, no?

@adcxyz
Copy link
Contributor Author

adcxyz commented Jul 13, 2017

yes, could also be a new issue - the problem is more general / conceptual,
namely what the clearest form of description is and how to write passing things
down into the elements so they work correctly. My current idea is loosely:

// element desc of an auto-expanding group:
(
    // things that describe the group, such as name:
    key: \dings, 
// this determines which set of what elements are made:
    groupType: \noteOnOffCtl, 
// this expands into list that goes into  elements one by one:
    midiNum: [24, 24, 48], 
    // everything the elements share
    shared: (
        style: (row: 0, column: 1), 
    ), 
    // maybe allow adding extra elements that go into the group
    // not really sure this is a good idea 
    elements: [ 
         (elementType: \led, ioType: \out), 
    ]
)
)

This should also include elements that have separate midiNums for output
(e.g. setting moving faders or led indicators), not sure how best to do that.

opinions please :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants