Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use FMOD library (不要使用 FMOD 库) #116

Open
Icenowy opened this issue Jan 11, 2017 · 14 comments
Open

Do not use FMOD library (不要使用 FMOD 库) #116

Icenowy opened this issue Jan 11, 2017 · 14 comments

Comments

@Icenowy
Copy link

Icenowy commented Jan 11, 2017

This program is licensed under GPLv3, which makes everything binary that is distributed with it should be opensourced.
If FMOD is redistributed with QSanguosha, user will have the permission to ask QSanguosha for the source of FMOD, which is impossible to satisfy.
Another choice is to ask every developer for permission to add a exception that allows the usage of FMOD.
However, this will prevent QSanguosha from running on non-x86 Linux, non-x86 Mac, etc platforms.

本程序使用 GPLv3 授权,要求所有一同分发的 binary 都开源。
如果 FMOD 与 QSanguosha 同时分发,用户将会有权向 QSanguosha 索要 FMOD 的源码,而这是不可能被满足的要求。
另外的选项是征求所有开发者的意见,加入一个 exception 允许使用 FMOD。
但是这样又会让 QSanguosha 无法在 non-x86 Linux, non-x86 Mac 等平台上运行。

@Fsu0413
Copy link
Collaborator

Fsu0413 commented Jan 11, 2017

本来我们打算换掉fmod的,尝试过QAudioPlayer+oggvorbis,最后效果不是很尽如人意。
如果你能提供一个比较好的换掉fmod的方式的话,我们倒是很高兴可以接受提案。

@LiXiaYu
Copy link

LiXiaYu commented Jan 13, 2017

If you distribute the DLLs with the program, they won't be eligible for this exception anymore; then the only way to comply with the GPL would be to provide their source code, which you are unable to do.

Do it means that, As long as you do not release the FMOD DLL with QSanguosha, it can be seen as "system library" or "runtime" to use?
这句话的意思是不是:只要不随着QSanguosha发布FMOD的dll,那就可以看作“系统库”还是“运行时”来使用?

@Icenowy
Copy link
Author

Icenowy commented Jan 13, 2017 via email

@Fsu0413
Copy link
Collaborator

Fsu0413 commented Jan 15, 2017

如果不随着QSanguosha发布fmod的dll的话,大部分系统都无法打开QSanguosha了。
目前QSanguosha的维护者不是我,我不认为现在的维护者会有替换掉fmod的想法。

不知道程序刚刚起步的时候为什么考虑使用fmod,具体的原因可能只能问5年前的开发者了。
查了一下版本历史,在2012年1月16日,音频库由irrKlang换成了fmod,具体原因不得而知,当时我还没参与维护。

@Icenowy
Copy link
Author

Icenowy commented Jan 15, 2017 via email

@Fsu0413
Copy link
Collaborator

Fsu0413 commented Jan 15, 2017

所以我现在也不知道该怎么办了。。。
这样吧,我先把fmod相关的东西从源码库删掉吧,解决办法等以后再说

@LiXiaYu
Copy link

LiXiaYu commented Jan 16, 2017

倒是可以附个下载链接,让人手动下载

@yohannliang
Copy link

Fmodex能下载吗?好像弃用掉了,大家是转成Fmod Studio的吗,不然怎么编译?

@LiXiaYu
Copy link

LiXiaYu commented Dec 5, 2017

@yohannliang 我是用的以前附带的dll,可以去我的那个分支里面找找

@yohannliang
Copy link

@LiXiaYu 编译成功了...只是我觉得这个版本好像很远古

@LiXiaYu
Copy link

LiXiaYu commented Dec 12, 2017

@yohannliang 不会吧,我上次才从最新的分支上拉出来的。。。
https://github.com/LiXiaYu/QSanguosha-v2/tree/lixiayu_win10_msvc15x64_vs2017
应该是这个分支

@yohannliang
Copy link

https://tieba.baidu.com/p/5276904290
我是指相比于这个版本,master这个版本很远古了...当然,这好像不是由v2的源码直接来的,而是采用了tangjs520的源码,然而搜了一下,发现能找到的tangjs520源码,也很远古_(´ཀ`」 ∠)。

@LiXiaYu
Copy link

LiXiaYu commented Dec 18, 2017

原来是这个啊,话说@yohannliang 找不到随同发行的源码吗?可以索要的吧,这符合开源规则

@bioxun
Copy link

bioxun commented Jun 16, 2018

只要用FMOD的.dll,不用它的.lib,就仍然可以使用FMOD啊。
实现不了吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants