Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up a review process for new data with goal to have review pre-merge #43

Open
Lnaden opened this issue Apr 13, 2020 · 1 comment
Open
Labels
Enhancement New feature or request for the website, cross-linkings, presentations, etc.

Comments

@Lnaden
Copy link
Collaborator

Lnaden commented Apr 13, 2020

A review process needs to be established for data.

One process, proposed at the onset of the project was to just merge all data as it came in, and give it a color coded system to indicate review. It has been pointed out that this will likely lead to chaos and be hard to maintain.

Another process suggested was to have data be reviewed before it ever gets merged and I think this is what should be done. The pipeline would be like this:

  • Contributing person accumulates all data they wish to submit and open a PR with their own assessment of the quality of the data.
  • That assessment is reviewed by the curation team for that type of data
  • Adjustments are made / discussed in PR
  • Quality is assessed and noted in the PR
  • Merged

cc @Andrew-AbiMansour @sjayellis @jchodera

@Lnaden Lnaden added the Enhancement New feature or request for the website, cross-linkings, presentations, etc. label Apr 13, 2020
@sjayellis
Copy link
Collaborator

I second that a pre-merge review process would be a better strategy. This allows all discussion about the data and its quality to be tied to a PR.
The PR can also be used as a reference point for issues made, which may be a possibility for further discussion about the data quality after it has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request for the website, cross-linkings, presentations, etc.
Projects
None yet
Development

No branches or pull requests

2 participants