Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Keybinding import/export bug. 1.2.0 (1401) #652

Closed
3 of 4 tasks
Fred-IV opened this issue Dec 29, 2024 · 7 comments · Fixed by #653
Closed
3 of 4 tasks

🐞 Keybinding import/export bug. 1.2.0 (1401) #652

Fred-IV opened this issue Dec 29, 2024 · 7 comments · Fixed by #653
Assignees
Labels

Comments

@Fred-IV
Copy link

Fred-IV commented Dec 29, 2024

Bug Description

2 dev builds have come out today, and as I was about to report the issue on the first one, another update came along, so I tried it too, and same problem.
I export my keybindings on one Mac, and try to import on the 2nd Mac, and they are all wrong.
It changed the 3 key combo (ctrl, cmd, alt) to fn.
I don't have a Mac fn key on my keybopards.
So, I am using the 3 modifier keys and the keypad.
To move the windows top, bottom, left, right, corners, and center.
When I import the file on the 2nd Mac, they are all wrong.

Source Mac is on Sonoma 14.7.1
Destination Mac is on Sequoia 15.2
Both are on Loop 1.2.0 (1401)

Steps To Reproduce

  1. Export keybinds on one Mac
  2. Import keybindings on 2nd Mac.
  3. See failure.
    4

Expected Behavior

For the keybindings to be correct.

Actual Behavior

Changes the 3 modifier keys to a non-existent mac-fn key.

Screenshots

Loop Keybinds.json.zip
image
image

macOS Version

15.2 (24C101)

Loop Version

1.2.0 (1401)

Additional Context

No response

Final Checks

  • My issue is written in English
  • My issue title is descriptive
  • This is a single bug (multiple bugs should be reported individually)
  • I can help with fixing or developing this issue (tick if you can help).
@Fred-IV Fred-IV added the Bug label Dec 29, 2024
@Fred-IV
Copy link
Author

Fred-IV commented Dec 29, 2024

It looks like the problem is that is is NOT saving and loading the correct trigger key.

@MrKai77
Copy link
Owner

MrKai77 commented Dec 29, 2024

The trigger key currently doesn't save in the exported keybinds file. But that would make sense, will try and implement this tomorrow!

@MrKai77 MrKai77 self-assigned this Dec 30, 2024
@MrKai77 MrKai77 linked a pull request Dec 30, 2024 that will close this issue
@Fred-IV
Copy link
Author

Fred-IV commented Dec 30, 2024

I got the update, and tried it, but now it crashes after the import.
I tried 3 times, all 3 crashed, but it looks like it did take the trigger change, so I think it crashes after the import works.
I submitted all crashes and clicked reopen. When I reopened, and checked, the trigger key was changed.

@MrKai77 MrKai77 reopened this Dec 30, 2024
@MrKai77
Copy link
Owner

MrKai77 commented Dec 30, 2024

Would you be able to send your keybinds file here? I will try importing it on my end. (from the latest version, unlike the one in your original report?)

Edit: or is this happening when importing the original file?

@Fred-IV
Copy link
Author

Fred-IV commented Dec 30, 2024

I just verified, and it's the same as the first zip I sent. No changes.

@MrKai77
Copy link
Owner

MrKai77 commented Dec 30, 2024

Try the latest development build, should be fixed now!

@MrKai77 MrKai77 changed the title Keybinding import/export bug. 1.2.0 (1401) 🐞 Keybinding import/export bug. 1.2.0 (1401) Dec 30, 2024
@Fred-IV
Copy link
Author

Fred-IV commented Dec 30, 2024

so far, so good...

thanks, I'll report anything new if it comes up.

@MrKai77 MrKai77 closed this as completed Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants