Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: f, F, t and T motions for vi mode #230

Open
MrPicklePinosaur opened this issue Aug 7, 2023 · 1 comment
Open

[Feature]: f, F, t and T motions for vi mode #230

MrPicklePinosaur opened this issue Aug 7, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@MrPicklePinosaur
Copy link
Owner

MrPicklePinosaur commented Aug 7, 2023 •
edited
Loading

What would you like to see added?

Part of #96

Support f<motion> family of keybindings in vi mode implementation. These keys take in a character and will seek to it. See vim's documentation on how these motions work for implementation details.

Implementation suggestions

  • Add support for these motions in the vi mode parser, which can be found in shrs_vi crate
  • Implement the actual behavior in crates/shrs_line/src/vi.rs

See also the merged issue #181 as a reference
@MrPicklePinosaur MrPicklePinosaur added enhancement New feature or request good first issue Good for newcomers labels Aug 7, 2023
Kyllingene added a commit to Kyllingene/shrs that referenced this issue Dec 20, 2023
@Kyllingene
Should close MrPicklePinosaur#230, but not tested
20551ef
@MrPicklePinosaur
Copy link
Owner Author

blocked by #350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MrPicklePinosaur