NgrxFormControlDirective
: Update view when ngrxValueConverter
changes
#283
Labels
NgrxFormControlDirective
: Update view when ngrxValueConverter
changes
#283
Describe the bug
When
ngrxValueConverter
is changed butngrxFormControlState
is not, the view will not be updated.At a code level, we can easily observe this to be the case by noting that the directive does not use
ngOnChanges
and thatngrxValueConverter
has no setter behavior (likengrxFormControlState
does).Repro
StackBlitz: https://ngrx-forms-test-29yhcc.stackblitz.io
Note that "price" is using a converter that changes when "tax" changes (see selectors), but when we change tax, we see no change in price.
Click the "Fix" button to monkey-patch NgrxFormControlDirective and see how it should probably work.
The text was updated successfully, but these errors were encountered: