Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) teleporting all the minecarts #326

Open
thiefa opened this issue Jun 18, 2014 · 5 comments
Open

(Feature) teleporting all the minecarts #326

thiefa opened this issue Jun 18, 2014 · 5 comments
Labels

Comments

@thiefa
Copy link

thiefa commented Jun 18, 2014

Hi,
Is there a way to make MV-Portals teleport any minecart that enters a gate?

i use Bytecart as railroad system, but it needs chestcarts as track/destination updaters/checkers, so it would be important for me, that chestcarts (and any other carttyp) can use the portals from gate to gate, so the network knows of each other.

@fernferret
Copy link
Member

There's an open pull-request related to this: #414

@Anuril
Copy link

Anuril commented Mar 9, 2016

I can't verify that my patch works with Bytecart, tested only with normal chestcarts/hoppercarts.

@thiefa
Copy link
Author

thiefa commented Mar 9, 2016

hi,
thanks for looking in to it.

aslong as it teleports the "inventory" of any cart proper, it will work just fine with bytecart.

@fernferret
Copy link
Member

@Anuril I haven't forgotten about your Pull Request 😄 I cleaned all of the old crusty issues out as of last night.

I'll try to get around to looking at it tonight!

@fernferret fernferret self-assigned this Mar 9, 2016
@Anuril
Copy link

Anuril commented Mar 10, 2016

@thiefa, like i said, not ANY cart proper.

My code only copies the inventory of Storage Minecarts and Hoppers. I explicitly check for those two types of carts, as you can see in Line 91 of the File MVPVehicleListener.java

In the docs you can see that only those two Minecarts extend org.bukkit.inventory.InventoryHolder, which means no powered carts f.ex can be transported with inventory. (coal et al.)

https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/entity/minecart/package-tree.html

@fernferret: No Problem^^ It's already working on my server, which is why I initially fixed it :) Not just complaining to the developer but doing my part if I can..^^

@fernferret fernferret removed their assignment Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants