Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on deprecated request package #200

Open
JoshuaKGoldberg opened this issue Dec 28, 2023 · 1 comment
Open

Remove dependency on deprecated request package #200

JoshuaKGoldberg opened this issue Dec 28, 2023 · 1 comment

Comments

@JoshuaKGoldberg
Copy link

👋 Hi! Coming here from mochajs/mocha#5070: hyperlink is very nifty and I'm glad to have learned about it today, thanks! 😄

Right now there's a dependency on request, which is deprecated per request/request#3142. The native fetch should be sufficient to replace the one call to request() in this package:

request(

Would you accept a PR switching to fetch?

@papandreou
Copy link
Collaborator

papandreou commented Dec 29, 2023

Sure thing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants