Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPD_ERROR_MALFORMED on response lines longer than 4KiB #69

Open
joshkunz opened this issue Feb 11, 2021 · 1 comment
Open

MPD_ERROR_MALFORMED on response lines longer than 4KiB #69

joshkunz opened this issue Feb 11, 2021 · 1 comment

Comments

@joshkunz
Copy link

Howdy, I develop an MPD client called ashuffle that uses libmpdclient. A user filed an issue where a long comment on a track caused an mpd_recv_song as part of an mpd_list_all_meta command to fail with the error message Response line too large, which I presume is an MPD_ERROR_MALFORMED. It looks like this is caused by libmpdclient's fixed 4KiB buffer size. The user was able to confirm that a line in the raw response from MPD was over the 4KiB limit (4.4KiB). I have not directly confirmed this at HEAD but the issue appears to be in the code.

It looks like this has come up before in issue #51, and PR #53 has a proposed fix, but there hasn't been any activity on it in almost 10mo. Would the libmpdclient maintainers be open to moving forward with that, or another, fix?

@jcorporation
Copy link
Member

jcorporation commented Jul 17, 2021

A problem with the 4kB buffer limit poped up also in myMPD. A file was tagged with a comment longer than this limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants