Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain keywords confuse Quick Add #160

Open
thatoddmailbox opened this issue Sep 22, 2020 · 1 comment
Open

Certain keywords confuse Quick Add #160

thatoddmailbox opened this issue Sep 22, 2020 · 1 comment
Labels
bug Bugs or other similar issues quick add Related to Quick Add

Comments

@thatoddmailbox
Copy link
Member

It's a conflict between certain special behaviors and the name of the homework.

For example:

  • "Test asdf project 123" becomes "Test 123"
  • "Test on HW" becomes "Test"
    • Same thing happens with "for" or any of the other "date-signalling keywords", for lack of a better word
  • "Check thing after lecture" becomes "Check thing lecture"
  • @amazansky probably has more examples (the first two came from him)
@thatoddmailbox thatoddmailbox added bug Bugs or other similar issues quick add Related to Quick Add labels Sep 22, 2020
@thatoddmailbox
Copy link
Member Author

Other broken examples:

  • "Do R tutorial tomorrow 18.05" (but the opposite, "Do R tutorial 18.05 tomorrow", works)
  • "10/12" gets parsed as December 1st, 2010
  • "Q4" gets interpreted as January 1st in the year 4

These all seem to be because the compromise library detects a date, but then our date parsing code gets confused and doesn't know what to do with it.

Honestly I'm not totally sure if compromise is really worth it (like, we might be able to get better results with our own code), but I don't really feel like rewriting the quick add code, so I'm probably just gonna hack around these problems 🙂 🙂 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or other similar issues quick add Related to Quick Add
Projects
None yet
Development

No branches or pull requests

1 participant