Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezones in Calendar #167

Open
thatoddmailbox opened this issue Nov 12, 2020 · 0 comments
Open

Timezones in Calendar #167

thatoddmailbox opened this issue Nov 12, 2020 · 0 comments
Labels
bug Bugs or other similar issues

Comments

@thatoddmailbox
Copy link
Member

If you create a recurring event before a daylight savings time shift, but let it recur until after that shift, it will appear to have moved backwards/forwards by an hour. Technically speaking, the server is correct to do this, since the event is happening another 24 (or 24*7, etc...) hours past its previous occurrence; however, it's probably not what the user is expecting.

This is part of a broader issue with Calendar: for the most part, we ignore timezones, doing everything on the server in UTC, and letting the client convert to "local time" (but the only "local time" that's actually tested is America/New_York). Events probably want to be specified as a local time + timezone? And then recurring events would be calculated within that timezone? I'm not actually completely sure how best to handle this...

@thatoddmailbox thatoddmailbox added the bug Bugs or other similar issues label Nov 12, 2020
thatoddmailbox added a commit to MyHomeworkSpace/api-server that referenced this issue Mar 18, 2021
…t of America/New_York for now

eventually the timezone should be somehow nicely be incorporated into the event UI

this is related to MyHomeworkSpace/client#167
thatoddmailbox added a commit to MyHomeworkSpace/api-server that referenced this issue Mar 18, 2021
…account

this is because the concept of a 'day' depends on the timezone, due to things
like daylight savings time

we do the tzdata lookup in CalculateTimes, which means it can error now. it's
possible we want to move that lookup somewhere else? there just doesn't seem to
be a great place to put it where it'd apply to all events

related to MyHomeworkSpace/client#167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or other similar issues
Projects
None yet
Development

No branches or pull requests

1 participant