Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoiding duplicate getheaders #113

Open
leto opened this issue May 22, 2020 · 1 comment
Open

Avoiding duplicate getheaders #113

leto opened this issue May 22, 2020 · 1 comment
Assignees
@leto
Labels
enhancement New feature or request

Comments

@leto
Copy link
Member

leto commented May 22, 2020

Decide if we should pull this in from KMD.

It will need a bit of modification, because in HUSH internals HUSH3 is not the same as ASSETCHAINS_SYMBOL[0], so we need to change that check to look for the HUSH3 asset chain name.

commit 431204467cfab7336a9785b06368607fc9082f08
Author: DeckerSU <[email protected]>
Date:   Thu Apr 16 07:36:03 2020

    net: Avoid duplicate getheaders requests
    
    https://github.com/bitcoin/bitcoin/pull/8054
    https://github.com/bitcoin/bitcoin/pull/8306 (revert)
    https://github.com/dashpay/dash/pull/1589
    https://github.com/dashpay/dash/pull/2032
@leto
Copy link
Member Author

leto commented Jun 19, 2020

This is a bandwidth-saving performance issue, not privacy or security. Nice to have but not critical

DenioD added a commit to DenioD/hush3 that referenced this issue Sep 12, 2020
@DenioD
Avoid duplicate getheaders requests MyHush#113, port from KomodoPlatf…
a50905b 
…orm#322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leto leto

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leto