Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getchaintxstats incorrectly counts some transactions #82

Open
leto opened this issue Feb 16, 2020 · 3 comments
Open

getchaintxstats incorrectly counts some transactions #82

leto opened this issue Feb 16, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@leto
Copy link
Member

leto commented Feb 16, 2020 •
edited
Loading

We assume there is 1 coinbase output per block in our algorithm, but Hush actually has 2, one for the miner and one for the FR output. This means that our "organic" stats are incorrect, which delete the count of coinbase from stats and assumes 1 per block.
@leto
Copy link
Member Author

leto commented Feb 24, 2020

Also, the first 128 blocks of Hush v3 mainnet had no block reward or FR, and so had 0 coinbase outputs. This is low priority to fix but would be nice.

@leto
Copy link
Member Author

leto commented Feb 24, 2020

The code should also take into account -ac_end, when BR ends, for completeness.

@leto
Copy link
Member Author

leto commented Mar 6, 2020

We now correctly count 2 coinbase per block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leto