From ae8a329df5056ad7ae25a40ecc40c20cca2f0d78 Mon Sep 17 00:00:00 2001 From: Conor Darcy Date: Thu, 17 Oct 2024 11:32:11 +0100 Subject: [PATCH] feat(table): removing unnecessary method --- .../components/stable/gux-table/example.html | 31 +------------------ .../gux-all-row-select/gux-all-row-select.tsx | 6 ---- .../tests/gux-all-row-select.spec.ts | 18 ----------- 3 files changed, 1 insertion(+), 54 deletions(-) diff --git a/packages/genesys-spark-components/src/components/stable/gux-table/example.html b/packages/genesys-spark-components/src/components/stable/gux-table/example.html index 72ef01715..470579dbd 100644 --- a/packages/genesys-spark-components/src/components/stable/gux-table/example.html +++ b/packages/genesys-spark-components/src/components/stable/gux-table/example.html @@ -438,26 +438,11 @@

Data table with sortable columns

Object table with rows selection

- -Select all -Deselect all - + @@ -986,20 +971,6 @@

Data table with fixed columns

}); - - const selectAll = document.getElementById('selectAll'); - const deselectAll = document.getElementById('deselecAll'); - const allRowSelect = document.getElementById('allRowSelect'); - - selectAll.addEventListener('click', () => { - allRowSelect.setIndeterminate(false); - allRowSelect.setChecked(true); - }); - - deselectAll.addEventListener('click', () => { - allRowSelect.setIndeterminate(false); - allRowSelect.setChecked(false); - }); })()" > .not-used { diff --git a/packages/genesys-spark-components/src/components/stable/gux-table/gux-all-row-select/gux-all-row-select.tsx b/packages/genesys-spark-components/src/components/stable/gux-table/gux-all-row-select/gux-all-row-select.tsx index 20c1fa135..7e1d316de 100644 --- a/packages/genesys-spark-components/src/components/stable/gux-table/gux-all-row-select/gux-all-row-select.tsx +++ b/packages/genesys-spark-components/src/components/stable/gux-table/gux-all-row-select/gux-all-row-select.tsx @@ -49,12 +49,6 @@ export class GuxAllRowSelect { this.inputElement.indeterminate = indeterminate; } - @Method() - async setChecked(checked: boolean): Promise { - this.selected = checked; - this.internalallrowselectchange.emit(this.selected); - } - async componentWillLoad(): Promise { this.i18n = await buildI18nForComponent( this.root, diff --git a/packages/genesys-spark-components/src/components/stable/gux-table/gux-all-row-select/tests/gux-all-row-select.spec.ts b/packages/genesys-spark-components/src/components/stable/gux-table/gux-all-row-select/tests/gux-all-row-select.spec.ts index c1618ca9b..6c27a05ec 100644 --- a/packages/genesys-spark-components/src/components/stable/gux-table/gux-all-row-select/tests/gux-all-row-select.spec.ts +++ b/packages/genesys-spark-components/src/components/stable/gux-table/gux-all-row-select/tests/gux-all-row-select.spec.ts @@ -27,22 +27,4 @@ describe('gux-all-row-select', () => { await component.setIndeterminate(false); expect(inputElement.indeterminate).toBe(false); }); - - it('should handle the setChecked method', async () => { - const html = ''; - const page = await newSpecPage({ components, html, language }); - - const component = page.rootInstance; - const inputElement = page.root.shadowRoot.querySelector('input'); - - expect(inputElement.checked).toBe(false); - - await component.setChecked(true); - await page.waitForChanges(); - expect(inputElement.checked).toBe(true); - - await component.setChecked(false); - await page.waitForChanges(); - expect(inputElement.checked).toBe(false); - }); });
First name Last name Age