From 49ee9b7981a90696e950072d8c71367fb05e9b28 Mon Sep 17 00:00:00 2001 From: Gavin Everett Date: Fri, 13 Oct 2023 11:47:21 +0100 Subject: [PATCH 1/2] refactor(inputs): updating focus styles updating focus styles COMUI-2348 --- .../gux-form-field-number.scss | 14 ++++++++++---- .../gux-form-field-number.tsx | 1 + .../gux-form-field-text-like.scss | 13 +++++++++---- .../gux-form-field-text-like.tsx | 1 + .../src/components/stable/gux-icon/readme.md | 2 +- 5 files changed, 22 insertions(+), 9 deletions(-) diff --git a/packages/genesys-spark-components/src/components/stable/gux-form-field/components/gux-form-field-number/gux-form-field-number.scss b/packages/genesys-spark-components/src/components/stable/gux-form-field/components/gux-form-field-number/gux-form-field-number.scss index e37f00cad..bff19f6c9 100644 --- a/packages/genesys-spark-components/src/components/stable/gux-form-field/components/gux-form-field-number/gux-form-field-number.scss +++ b/packages/genesys-spark-components/src/components/stable/gux-form-field/components/gux-form-field-number/gux-form-field-number.scss @@ -49,6 +49,16 @@ $gux-form-field-number-step-button-size: 14px; align-items: center; width: 100%; + &:focus-visible { + border: var(--gse-ui-formControl-input-default-border-width) + var(--gse-ui-formControl-input-default-border-style) + var(--gse-ui-formControl-input-default-border-color); + border-radius: var(--gse-ui-formControl-focusRing-borderRadius); + outline: var(--gse-ui-formControl-input-focus-border-width) + var(--gse-ui-formControl-input-focus-border-style) + var(--gse-ui-formControl-input-focus-border-color); + } + .gux-input-container { box-sizing: border-box; display: flex; @@ -87,10 +97,6 @@ $gux-form-field-number-step-button-size: 14px; border: var(--gse-ui-formControl-input-active-border-width) var(--gse-ui-formControl-input-active-border-style) var(--gse-ui-formControl-input-active-border-color); - border-radius: var(--gse-ui-formControl-focusRing-borderRadius); - outline: var(--gse-ui-formControl-input-focus-border-width) - var(--gse-ui-formControl-input-focus-border-style) - var(--gse-ui-formControl-input-focus-border-color); } } diff --git a/packages/genesys-spark-components/src/components/stable/gux-form-field/components/gux-form-field-number/gux-form-field-number.tsx b/packages/genesys-spark-components/src/components/stable/gux-form-field/components/gux-form-field-number/gux-form-field-number.tsx index c65b727ae..7417d184e 100644 --- a/packages/genesys-spark-components/src/components/stable/gux-form-field/components/gux-form-field-number/gux-form-field-number.tsx +++ b/packages/genesys-spark-components/src/components/stable/gux-form-field/components/gux-form-field-number/gux-form-field-number.tsx @@ -137,6 +137,7 @@ export class GuxFormFieldNumber {
Date: Mon, 16 Oct 2023 09:57:11 +0100 Subject: [PATCH 2/2] test(inputs): update focus stylings update focus stylings COMUI-2348 --- .../gux-pagination-buttons.spec.ts.snap | 6 ++-- .../gux-form-field-number.e2e.ts.snap | 26 +++++++------- .../gux-form-field-number.spec.ts.snap | 26 +++++++------- .../gux-form-field-text-like.e2e.ts.snap | 36 +++++++++---------- .../gux-form-field-text-like.spec.ts.snap | 36 +++++++++---------- 5 files changed, 65 insertions(+), 65 deletions(-) diff --git a/packages/genesys-spark-components/src/components/legacy/gux-pagination-legacy/gux-pagination-buttons-legacy/tests/__snapshots__/gux-pagination-buttons.spec.ts.snap b/packages/genesys-spark-components/src/components/legacy/gux-pagination-legacy/gux-pagination-buttons-legacy/tests/__snapshots__/gux-pagination-buttons.spec.ts.snap index 12fa60335..5607bea7c 100644 --- a/packages/genesys-spark-components/src/components/legacy/gux-pagination-legacy/gux-pagination-buttons-legacy/tests/__snapshots__/gux-pagination-buttons.spec.ts.snap +++ b/packages/genesys-spark-components/src/components/legacy/gux-pagination-legacy/gux-pagination-buttons-legacy/tests/__snapshots__/gux-pagination-buttons.spec.ts.snap @@ -27,7 +27,7 @@ exports[`gux-pagination-item-counts-legacy #render should render as expected (1)
-
+
@@ -101,7 +101,7 @@ exports[`gux-pagination-item-counts-legacy #render should render as expected (2)
-
+
@@ -175,7 +175,7 @@ exports[`gux-pagination-item-counts-legacy #render should render as expected (3)
-
+
diff --git a/packages/genesys-spark-components/src/components/stable/gux-form-field/components/gux-form-field-number/tests/__snapshots__/gux-form-field-number.e2e.ts.snap b/packages/genesys-spark-components/src/components/stable/gux-form-field/components/gux-form-field-number/tests/__snapshots__/gux-form-field-number.e2e.ts.snap index b5d870be7..c8aa06b2b 100644 --- a/packages/genesys-spark-components/src/components/stable/gux-form-field/components/gux-form-field-number/tests/__snapshots__/gux-form-field-number.e2e.ts.snap +++ b/packages/genesys-spark-components/src/components/stable/gux-form-field/components/gux-form-field-number/tests/__snapshots__/gux-form-field-number.e2e.ts.snap @@ -8,7 +8,7 @@ exports[`gux-form-field-number #render clearable should render component as expe
-
+
@@ -44,7 +44,7 @@ exports[`gux-form-field-number #render clearable should render component as expe
-
+
@@ -81,7 +81,7 @@ exports[`gux-form-field-number #render clearable should render component as expe
-
+
@@ -118,7 +118,7 @@ exports[`gux-form-field-number #render clearable should render component as expe
-
+
@@ -154,7 +154,7 @@ exports[`gux-form-field-number #render clearable should render component as expe
-
+
@@ -190,7 +190,7 @@ exports[`gux-form-field-number #render help should render component as expected
-
+
@@ -226,7 +226,7 @@ exports[`gux-form-field-number #render input attributes should render component
-
+
@@ -262,7 +262,7 @@ exports[`gux-form-field-number #render input attributes should render component
-
+
@@ -298,7 +298,7 @@ exports[`gux-form-field-number #render input attributes should render component
-
+
@@ -334,7 +334,7 @@ exports[`gux-form-field-number #render label-position should render component as
-
+
@@ -370,7 +370,7 @@ exports[`gux-form-field-number #render label-position should render component as
-
+
@@ -406,7 +406,7 @@ exports[`gux-form-field-number #render label-position should render component as
-
+
@@ -442,7 +442,7 @@ exports[`gux-form-field-number #render label-position should render component as
-
+
diff --git a/packages/genesys-spark-components/src/components/stable/gux-form-field/components/gux-form-field-number/tests/__snapshots__/gux-form-field-number.spec.ts.snap b/packages/genesys-spark-components/src/components/stable/gux-form-field/components/gux-form-field-number/tests/__snapshots__/gux-form-field-number.spec.ts.snap index 7ad10519b..f7a7c224b 100644 --- a/packages/genesys-spark-components/src/components/stable/gux-form-field/components/gux-form-field-number/tests/__snapshots__/gux-form-field-number.spec.ts.snap +++ b/packages/genesys-spark-components/src/components/stable/gux-form-field/components/gux-form-field-number/tests/__snapshots__/gux-form-field-number.spec.ts.snap @@ -8,7 +8,7 @@ exports[`gux-form-field-number #render clearable should render component as expe
-
+
@@ -50,7 +50,7 @@ exports[`gux-form-field-number #render clearable should render component as expe
-
+
@@ -93,7 +93,7 @@ exports[`gux-form-field-number #render clearable should render component as expe
-
+
@@ -136,7 +136,7 @@ exports[`gux-form-field-number #render clearable should render component as expe
-
+
@@ -178,7 +178,7 @@ exports[`gux-form-field-number #render clearable should render component as expe
-
+
@@ -220,7 +220,7 @@ exports[`gux-form-field-number #render help should render component as expected
-
+
@@ -265,7 +265,7 @@ exports[`gux-form-field-number #render input attributes should render component
-
+
@@ -307,7 +307,7 @@ exports[`gux-form-field-number #render input attributes should render component
-
+
@@ -349,7 +349,7 @@ exports[`gux-form-field-number #render input attributes should render component
-
+
@@ -391,7 +391,7 @@ exports[`gux-form-field-number #render label-position should render component as
-
+
@@ -433,7 +433,7 @@ exports[`gux-form-field-number #render label-position should render component as
-
+
@@ -475,7 +475,7 @@ exports[`gux-form-field-number #render label-position should render component as
-
+
@@ -517,7 +517,7 @@ exports[`gux-form-field-number #render label-position should render component as
-
+
diff --git a/packages/genesys-spark-components/src/components/stable/gux-form-field/components/gux-form-field-text-like/tests/__snapshots__/gux-form-field-text-like.e2e.ts.snap b/packages/genesys-spark-components/src/components/stable/gux-form-field/components/gux-form-field-text-like/tests/__snapshots__/gux-form-field-text-like.e2e.ts.snap index bed12306a..bca46666b 100644 --- a/packages/genesys-spark-components/src/components/stable/gux-form-field/components/gux-form-field-text-like/tests/__snapshots__/gux-form-field-text-like.e2e.ts.snap +++ b/packages/genesys-spark-components/src/components/stable/gux-form-field/components/gux-form-field-text-like/tests/__snapshots__/gux-form-field-text-like.e2e.ts.snap @@ -8,7 +8,7 @@ exports[`gux-form-field-text-like #render clearable should render component as e
-
+
@@ -38,7 +38,7 @@ exports[`gux-form-field-text-like #render clearable should render component as e
-
+
@@ -69,7 +69,7 @@ exports[`gux-form-field-text-like #render clearable should render component as e
-
+
@@ -100,7 +100,7 @@ exports[`gux-form-field-text-like #render clearable should render component as e
-
+
@@ -130,7 +130,7 @@ exports[`gux-form-field-text-like #render clearable should render component as e
-
+
@@ -160,7 +160,7 @@ exports[`gux-form-field-text-like #render help should render component as expect
-
+
@@ -190,7 +190,7 @@ exports[`gux-form-field-text-like #render input type attribute should render com
-
+
@@ -220,7 +220,7 @@ exports[`gux-form-field-text-like #render input type attribute should render com
-
+
@@ -250,7 +250,7 @@ exports[`gux-form-field-text-like #render input type attribute should render com
-
+
@@ -280,7 +280,7 @@ exports[`gux-form-field-text-like #render label-position should render component
-
+
@@ -310,7 +310,7 @@ exports[`gux-form-field-text-like #render label-position should render component
-
+
@@ -340,7 +340,7 @@ exports[`gux-form-field-text-like #render label-position should render component
-
+
@@ -370,7 +370,7 @@ exports[`gux-form-field-text-like #render label-position should render component
-
+
@@ -400,7 +400,7 @@ exports[`gux-form-field-text-like #render prefix should render component as expe
-
+
@@ -430,7 +430,7 @@ exports[`gux-form-field-text-like #render suffix should render component as expe
-
+
@@ -460,7 +460,7 @@ exports[`gux-form-field-text-like input attributes should render component as ex
-
+
@@ -490,7 +490,7 @@ exports[`gux-form-field-text-like input attributes should render component as ex
-
+
@@ -520,7 +520,7 @@ exports[`gux-form-field-text-like input attributes should render component as ex
-
+
diff --git a/packages/genesys-spark-components/src/components/stable/gux-form-field/components/gux-form-field-text-like/tests/__snapshots__/gux-form-field-text-like.spec.ts.snap b/packages/genesys-spark-components/src/components/stable/gux-form-field/components/gux-form-field-text-like/tests/__snapshots__/gux-form-field-text-like.spec.ts.snap index e710d4e39..ae4bfc057 100644 --- a/packages/genesys-spark-components/src/components/stable/gux-form-field/components/gux-form-field-text-like/tests/__snapshots__/gux-form-field-text-like.spec.ts.snap +++ b/packages/genesys-spark-components/src/components/stable/gux-form-field/components/gux-form-field-text-like/tests/__snapshots__/gux-form-field-text-like.spec.ts.snap @@ -8,7 +8,7 @@ exports[`gux-form-field-text-like #render clearable should render component as e
-
+
@@ -44,7 +44,7 @@ exports[`gux-form-field-text-like #render clearable should render component as e
-
+
@@ -81,7 +81,7 @@ exports[`gux-form-field-text-like #render clearable should render component as e
-
+
@@ -118,7 +118,7 @@ exports[`gux-form-field-text-like #render clearable should render component as e
-
+
@@ -154,7 +154,7 @@ exports[`gux-form-field-text-like #render clearable should render component as e
-
+
@@ -190,7 +190,7 @@ exports[`gux-form-field-text-like #render help should render component as expect
-
+
@@ -229,7 +229,7 @@ exports[`gux-form-field-text-like #render input attributes should render compone
-
+
@@ -265,7 +265,7 @@ exports[`gux-form-field-text-like #render input attributes should render compone
-
+
@@ -301,7 +301,7 @@ exports[`gux-form-field-text-like #render input attributes should render compone
-
+
@@ -337,7 +337,7 @@ exports[`gux-form-field-text-like #render input type attribute should render com
-
+
@@ -373,7 +373,7 @@ exports[`gux-form-field-text-like #render input type attribute should render com
-
+
@@ -409,7 +409,7 @@ exports[`gux-form-field-text-like #render input type attribute should render com
-
+
@@ -445,7 +445,7 @@ exports[`gux-form-field-text-like #render label-position should render component
-
+
@@ -481,7 +481,7 @@ exports[`gux-form-field-text-like #render label-position should render component
-
+
@@ -517,7 +517,7 @@ exports[`gux-form-field-text-like #render label-position should render component
-
+
@@ -553,7 +553,7 @@ exports[`gux-form-field-text-like #render label-position should render component
-
+
@@ -589,7 +589,7 @@ exports[`gux-form-field-text-like #render prefix should render component as expe
-
+
@@ -628,7 +628,7 @@ exports[`gux-form-field-text-like #render suffix should render component as expe
-
+