You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
extract_datetime_en() (at minimum, and possibly other languages) returns a tuple when it's successful, but it returns None when it doesn't find a datetime.
@JarbasAl has discovered that this (obviously) fails to unpack. This can (and should) be resolved by returning (None, utterance) when no datetime is found, just as it returns (Datetime, remainder) when successful.
However, as @JarbasAl pointed out, some folks in the wild might be wrapping the problem:
ifextract_datetime(...):
datething= ...
so simply removing the None output could break something, somewhere.
Hence, we'd like to slap a big ol' DeprecationWarning on this and fix it in, say, four alpha-minor or one "major" (minor) release.
The text was updated successfully, but these errors were encountered:
extract_datetime_en()
(at minimum, and possibly other languages) returns a tuple when it's successful, but it returnsNone
when it doesn't find a datetime.@JarbasAl has discovered that this (obviously) fails to unpack. This can (and should) be resolved by returning
(None, utterance)
when no datetime is found, just as it returns(Datetime, remainder)
when successful.However, as @JarbasAl pointed out, some folks in the wild might be wrapping the problem:
so simply removing the
None
output could break something, somewhere.Hence, we'd like to slap a big ol' DeprecationWarning on this and fix it in, say, four alpha-minor or one "major" (minor) release.
The text was updated successfully, but these errors were encountered: