-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate or implement formatters from official datetime skill #198
Comments
Yeah this seems like a good thing to pull out, I can imagine many things wanting to have a nice looking day / date / month and whilst the Skills API is great, these would be broadly used including outside Mycroft. Would the following cover everything?
Given nice_day and nice_year would both be wrapping a single In I can see the leap year stuff fitting into the current |
I will be looking at the date/time skill next week to give it some much needed TLC. Once I've had a chance to familiarize myself with the skill again I will provide some feedback. |
* feat/nice_date utils MycroftAI#198 * @localized_function(run_own_code_on=[FunctionNotLocalizedError]) * MDY/DMY/YMD
The official DateTime Skill currently contains some nifty
get_x()
functions for relevant information, most of which just expose things from Lingua Franca. Others retrieve info from LF and then mutate it a bit. Clever little formatters.These are very useful to other Skills, and not only Skills! I became aware of them because @AIIX used them for home screen info. Anything that wants to display the date or a schedule could benefit, so I think LF should support that stuff directly. We're halfway there already with
nice_time()
.We could start by simply migrating the functions from the Skill and seeing if anything even needs further localization. At a glance, it looks like it's built around
lingua_franca.format.date_time_format
.@chrisveilleux thoughts from the Skill side of things?
The text was updated successfully, but these errors were encountered: