Look for any bugs reported downstream or in our github issues and fix them:
- https://github.com/resurrecting-open-source-projects/scrot/issues
- https://bugs.debian.org/cgi-bin/pkgreport.cgi?dist=unstable;package=scrot
- https://bugs.launchpad.net/ubuntu/+source/scrot/+bugs
- https://apps.fedoraproject.org/packages/scrot/bugs
- https://bugs.gentoo.org/buglist.cgi?quicksearch=scrot
Integrate libbsd
The BSD systems provide nonstandard C functions; many of the functions remove the need for some boilerplate code, and provide safer or easier to use APIs compared to the C standard library. scrot is in the process of auditing its source to make use of BSD extensions to the C library where they are found to improve code quality. scrot depends on libbsd to provide the required functions where they're missing to remain portable. libbsd includes manuals for all the functions it implements-a list of them can be found at libbsd(7). The manual can alternatively be accessed from the web at manpages.debian.org. BSD systems provide manuals for these functions in the default install.
The following libbsd integration efforts are in progress:
Replace strncpy() and strcpy() calls with strlcpy().Replace strcat() and strncat() calls with strlcat().Replace error exits with the err() family of functions.Replace local implementations of data structures with the sys/queue.h API.- Find places where other BSD functions can serve scrot well.
We're currently in the process of complying with the new obligatory C style described in CONTRIBUTING.md.
The following files are yet to be converted:
src/imlib.csrc/main.csrc/note.csrc/options.csrc/scrot_selection.csrc/selection_classic.csrc/selection_edge.csrc/note.hsrc/options.hsrc/slist.csrc/scrot.hsrc/scrot_selection.hsrc/selection_classic.hsrc/selection_edge.hsrc/slist.hsrc/structs.h