Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project: Lighting problems with latest SlicerVR #1382

Open
cpinter opened this issue Jan 23, 2025 · 4 comments
Open

Project: Lighting problems with latest SlicerVR #1382

cpinter opened this issue Jan 23, 2025 · 4 comments

Comments

@cpinter
Copy link
Contributor

cpinter commented Jan 23, 2025

Draft Status

Ready - team will start page creating immediately

Category

VR/AR and Rendering

Key Investigators

  • Csaba Pinter (EBATINCA, Spain)
  • Andras Lasso (PerkLab, Queen's, Canada)
  • Matt Jolley (CHOP, USA)
  • Kitware? (Jc / Thibault)

Project Description

There is a regression with how latest SlicerVR lights the scene, both with the old VR and the new XR backend.

  • OpenVR: Default lighting looks as expected, but now SSAO and Lights module options are not applied on the VR view (even if the view node IDs are explicitly selected)
  • OpenXR: Default lighting looks washed out

Objective

  1. Make both backends of SlicerVR work like before the regression
    • "Normal" lighting by default
    • Lights module changes have effect on VR view as well

Approach and Plan

  1. Investigate the problem with the help of people directly involved in the OpenXR integration
  2. If we find the root cause of either issues, try to address them

Progress and Next Steps

  1. Describe specific steps you have actually done.

Illustrations

The following screenshots demonstrate shadows vs no shadows in OpenVR:

Image
Left: Slicer view using OpenVR without shadows
Right: VR view (with back lights / without two sided lighting)

Image
Left: Slicer view using OpenVR with shadows
Right: VR view (with back lights / without two sided lighting)


The following screenshots demonstrate different lighting options in OpenXR:

Image
Left: Slicer view using OpenXR without shadows
Right: VR view (with back lights / without two sided lighting)

Image
Left: Slicer view using OpenXR without shadows
Right: VR view (without back lights / without two sided lighting)

Background and References

For those who have access to SlicerHeart internals, this is the link to the issue: https://github.com/JolleyLab/Internal/issues/205#event-14879920416

@mattjolley
Copy link
Collaborator

@cpinter and team

Thank you for working on this. Let us know how we can support further testing as above.

@iacovellaj and @sp318 are happy to test on our Vive Pro 2 and Meta Quest Pro.

It would be great if the lighting features in OpenVR (or similar) are implemented in the OpenXR version.

@sjh26
Copy link
Contributor

sjh26 commented Jan 23, 2025

@cpinter it looks like none of the image urls are working?

@sjh26 sjh26 added draft and removed ready labels Jan 23, 2025
@cpinter
Copy link
Contributor Author

cpinter commented Jan 23, 2025

Hm, maybe I can see them because I am a member of that private repo. I thought these ridect links worked anyway. It seems they fixed it. Thanks for letting me know, I'll replace them.

@sjh26
Copy link
Contributor

sjh26 commented Jan 23, 2025

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants