-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImplicitTiling looping request #728
Comments
The positioning of the tile set in the index example is a bit odd 😅 Maybe the automatic positioning logic could be improved. But I was able to get it in frame once and wasn't seeing any errors so this may need a more succinct repro. |
index.js.txt Screencast.from.30-08-2024.10.12.31.webm |
I see it now - I think this is related to #726 which I noticed last week. The LRUCache unload behavior isn't working correctly so I need to spend some time this next week figuring out what's going on. Setting the error target to 0 causes the buggy lru cache behavior to kick in. Also I see that this tile set has two extremely far clusters of tiles making it difficult to see the extent / find the geometry: Adding a new debug settings to display parent tile bounds (Both empty and not empty) would make tile sets like this easier to understand. |
@AnthonyGlt do you mind retrying your test? The issue should have been fixed in #726, #727. I still want to fix #741 before a new release but everything should be stable again. |
Yes it got fixed, well done ! :D |
When I load this link https://storage.googleapis.com/ahp-research/projects/sogelink/hackathon/bdnb/sampleset/tileset.json which has implicitTiling
The data is loading as expected but once everything is loaded, the
0_0_0.subtree
is fetched again and provoking errorsMaybe it's caused by one of the implementations left todo but I don't see which one it could be
To Reproduce
Steps to reproduce the behavior:
example/index.js
to load the linkgeospatialRotationParent.scale.set( 1, 1, 1 );
bygeospatialRotationParent.scale.set( 0.01, 0.01, 0.01 );
because the dataset is bigerrorTarget
&errorThreshold
at0
+ checkeddisplayRegionBounds
Screenshots
The text was updated successfully, but these errors were encountered: