-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not all email notifications are being triggered #748
Comments
@wrynearson This will need to be our next priority following the PDF upload workflow. This was brought to my attention yesterday by a user. We can discuss further at our tagup June 5. |
Hi @bwbaker1, if you see this before our meeting today, could you give a few more details? Which user noticed this (and email address), and for which actions? Or is this list from internal testing? @thenav56 tested this locally and didn't find anything wrong with the notification code itself. The issue is either coming from AWS or that the user's email domain is blocking the email. We had similar issues with SNWG for the latter reason. We currently don't have |
@wrynearson This is the document that first caught my attention ([Chlorophyll a) (Guoqing Wang - [email protected]). I didn't receive a notification when the author requested review. She reached out to me via email. Then Camille and I tested internally (bwbaker1 - [email protected] and cw0045 - [email protected]). We tested all of the listed actions above and neither of us received notifications. We checked spam mailboxes as well. |
OK thanks @bwbaker1, this is good to know. I'll chat with the team to look into this. |
@bwbaker1 Do you have the approximate time for those actions? That would help us filter the logs. |
@sunu Thanks for checking into this. The actions triggered by [email protected] and [email protected] were on June 1 between 10am-1030am central standard time. |
Hi @bwbaker1, we think that the email issues are related to AWS Simple Email Service (SES) account permissions. According to the documentation, SES accounts are first placed in a "sandbox" which applies restrictions. The number of emails that can be sent per 24h is limited to 200, which could be an issue in the future. Most likely, the current issue is that emails can only be sent to and from verified email addresses. Is it possible that Guoqing's email is not verified in the system? If hers is verified, the issue could be that our email sending service isn't verified. I'd suggest that someone at IMPACT requests to move your Amazon SES account out of the sandbox by following these instructions. |
@wrynearson I double-checked and Guoqing's email is verified. @xhagrg @michaelsfoley See comment. Is this something that either of you can help with? Or can you direct me to who could help? |
We should also check that the sender email identity is verified. We had a similar issue on SNWG that @xhagrg helped us fix by verifying the sender email address on SES |
@wrynearson I think this is done, but let us do some testing over the next few days. Will close if everything is working properly. |
@wrynearson I'm now aware that two notifications are not being triggered from users. 1. When document review is requested and 2. When document publication is requested. I'm certain the document review request notification was working before. |
@thenav56 would you have the chance to look into this? @bwbaker1 I want to flag that on staging, your account is both a contributor and a curator. If you were testing there with your account, that could explain why you weren't receiving some emails, but I'm not sure how both roles would interfere with each other in regards to email notifications. I did get the following notifications from |
@wrynearson This is happening on production. A user requested a document be published, and I didn't receive anything. She sent me an email several days later asking to publish she. She also said that she did not get a notification when she made the request. |
@bwbaker1 I would recommend that we find time to have DevSeed sync with you to be able to see the production logs, as we're having a difficult time debugging email notifications. There are many potential reasons for emails not being delivered, so we should first see if there's anything blocking us sending the emails in the first place. |
@wrynearson Sure. Let me know some day/times that works for you all and I will pick a time. |
@leothomas @sunu @thenav56 (but I don't think all of you need to be there) cc @batpad |
Description
Not all email notifications are being triggered when specific actions are made. Notifications related to document transitions (e.g., curator notified when reviewers conclude review) is very important. These will be especially important soon as we have several ATBDs that will potentially be moving between stages. We want to ensure that the curator doesn't cause any user delays, but also ensure authors/reviewers are aware of where the documents stand. For now, the curator can check the dashboard daily and send author/reviewers email if needed.
Spreadsheet - This sheet shows the higher priority notifications that need to be fixed/implemented.
**Tasks:
Acceptance Criteria
The text was updated successfully, but these errors were encountered: