Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check into why some figure images do not always display on TEMPO ATBD #896

Open
Tracked by #872
bwbaker1 opened this issue Sep 26, 2024 · 3 comments
Open
Tracked by #872
Assignees

Comments

@bwbaker1
Copy link
Collaborator

bwbaker1 commented Sep 26, 2024

The TEMPO team is rather continuously encounter figure images not displaying on the generate PDF. Sometimes the captions are missing, but sometimes they are not (just related to images that don't appear.

TEMPO Nitrogen Dioxide Algorithm Theoretical Basis Document

Access can be granted for those with a production account (if needed). @wrynearson noticed a caching issue the other day, but doesn't seem to help now.

Acceptance Criteria

  • determine what is causing the issue
@wrynearson
Copy link
Member

@jjfrench can you think of any reason why this would be happening? cc @frozenhelium.

I have not been able to reproduce this issue – the figures I've tested all download as expected for me.

@jjfrench
Copy link
Contributor

Not entirely sure how these processes work but can we confirm it's a display issue or is the PDF not being generated properly? I can check for logs if I know what to look for (if it's a backend issue)

@wrynearson
Copy link
Member

Yes @jjfrench, it's a PDF generation and backend issue. The PDFs are generated using Playwright (see #622 and referenced issues/PRs for details).

It's strange because the generation is not happening on the user's side, but in the backend. Also, if a document hasn't been changed, we serve a cached version of the generated PDF. I don't understand why document PDFs that @bwbaker1 downloads would be different than the ones that I download, but they appear to be so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants