Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New function: cf.cell_overlaps #824

Open
davidhassell opened this issue Oct 30, 2024 · 1 comment · May be fixed by #825
Open

New function: cf.cell_overlaps #824

davidhassell opened this issue Oct 30, 2024 · 1 comment · May be fixed by #825

Comments

@davidhassell
Copy link
Collaborator

The current cf.cellwi(start, end) only matches cells that lie completely with the closed range [start, end].

Sometimes we would like to match cells that merely overlap the range.

I propose a new function cf.cell_overlaps(start, end) that does just this. It will be a constructor function for <CF Query: [upper_bounds(ge start) & lower_bounds(le end)]>

(Compare this with cf.cellwi, which is a constructor function for <CF Query: [lower_bounds(ge start) & upper_bounds(le end)]>)

The docstrings for the various Query constructor functions could also be improved to more accurately reflect what they do!

@davidhassell
Copy link
Collaborator Author

Having chatted about this off-line, we're going to park this until v4.0.0, when we can think about the best approach to bringing other "cell" methods into the fold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant