Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend test suite: cover array inputs + all methods #4

Open
sadielbartholomew opened this issue Apr 22, 2020 · 0 comments
Open

Extend test suite: cover array inputs + all methods #4

sadielbartholomew opened this issue Apr 22, 2020 · 0 comments
Labels
testing Issues related to units tests and their coverage

Comments

@sadielbartholomew
Copy link
Member

The test suite is overdue some love, notably because most of the > 50 methods in the Units class are not directly tested:

$ git grep "def " units.py | wc -l
65
$ git grep "def " test/test_Units.py | wc -l
5

where one of the latter five, test_Units_BINARY_AND_UNARY_OPERATORS, covers perhaps OOM 10 Units methods to some extent, but the rest focus on specific methods so still there is a deficit of ~50 methods to explicitly cover. And another of those five is very minimal as I just added it to expose 4060945).

Furthermore, the handling of NumPy objects is not tested at all (numpy is not imported in the test module). We should ensure this is tested where appropriate, e.g. to check that arrays are processed as expected.

@davidhassell davidhassell added the testing Issues related to units tests and their coverage label Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Issues related to units tests and their coverage
Projects
None yet
Development

No branches or pull requests

2 participants