Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(module:transfer): use nzOneWay to make Transfer the one way style #8717

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(module:transfer): use nzOneWay to make Transfer the one way style #8717

wants to merge 1 commit into from
+204 −71

Conversation

OriginRing
Copy link
Collaborator

fix: #8643

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@zorro-bot zorro-bot
Copy link

zorro-bot bot commented Aug 28, 2024

This preview will be available after the AzureCI is passed.

@codecov Codecov
Copy link

codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.13%. Comparing base (9e3bb3e) to head (4809583).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
components/transfer/transfer-list.component.ts 33.33% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8717      +/-   ##
==========================================
- Coverage   93.15%   93.13%   -0.02%     
==========================================
  Files         538      538              
  Lines       18457    18464       +7     
  Branches     2816     2816              
==========================================
+ Hits        17193    17197       +4     
- Misses       1226     1229       +3     
  Partials       38       38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

HyperLife1119
HyperLife1119 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@HyperLife1119 HyperLife1119 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Laffery
Laffery requested changes Aug 31, 2024
View reviewed changes
components/transfer/demo/on-way.ts Outdated Show resolved Hide resolved
components/transfer/transfer-list.component.ts Outdated Show resolved Hide resolved
@HyperLife1119
Copy link
Collaborator

HyperLife1119 commented Sep 3, 2024 •
edited
Loading

Please fix the CI :)

@HyperLife1119 HyperLife1119 added PR: need-test Test is necessary for code changes. and removed PR: reviewed-changes-requested labels Sep 10, 2024
@HyperLife1119 HyperLife1119 added this to the v19 milestone Sep 11, 2024
@HyperLife1119 HyperLife1119 removed the PR: need-test Test is necessary for code changes. label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyperLife1119 HyperLife1119 HyperLife1119 approved these changes

@Ricbet Ricbet Awaiting requested review from Ricbet Ricbet is a code owner

@Laffery Laffery Awaiting requested review from Laffery

Assignees
No one assigned
Labels
Component: Transfer PR: partially-approved PR: target-major
Projects
None yet
Milestone
v19
Development

Successfully merging this pull request may close these issues.

Transfer 支持单向样式
3 participants
@OriginRing @HyperLife1119 @Laffery