Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(module:*): use ECMAScript standard class field #8718

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

refactor(module:*): use ECMAScript standard class field #8718

wants to merge 2 commits into from

Conversation

Laffery
Copy link
Collaborator

@Laffery Laffery commented Aug 28, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: close #8660

What is the new behavior?

useDefineForClassFields: false in tsconfig.json has been removed, and

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@zorro-bot zorro-bot
Copy link

zorro-bot bot commented Aug 28, 2024

This preview will be available after the AzureCI is passed.

@codecov Codecov
Copy link

codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.54%. Comparing base (8c9bcd1) to head (46cd537).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
components/dropdown/dropdown.directive.ts 60.00% 2 Missing ⚠️
...s/notification/notification-container.component.ts 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8718      +/-   ##
==========================================
- Coverage   91.58%   91.54%   -0.04%     
==========================================
  Files         538      538              
  Lines       18459    18456       -3     
  Branches     2816     2817       +1     
==========================================
- Hits        16905    16895      -10     
- Misses       1237     1240       +3     
- Partials      317      321       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HyperLife1119 HyperLife1119 added this to the v19 milestone Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OriginRing OriginRing Awaiting requested review from OriginRing OriginRing will be requested when the pull request is marked ready for review OriginRing is a code owner

@danranVm danranVm Awaiting requested review from danranVm danranVm will be requested when the pull request is marked ready for review danranVm is a code owner

@vthinkxie vthinkxie Awaiting requested review from vthinkxie vthinkxie will be requested when the pull request is marked ready for review vthinkxie is a code owner

@wenqi73 wenqi73 Awaiting requested review from wenqi73 wenqi73 will be requested when the pull request is marked ready for review wenqi73 is a code owner

@wzhudev wzhudev Awaiting requested review from wzhudev wzhudev will be requested when the pull request is marked ready for review wzhudev is a code owner

@hsuanxyz hsuanxyz Awaiting requested review from hsuanxyz hsuanxyz will be requested when the pull request is marked ready for review hsuanxyz is a code owner

@cipchk cipchk Awaiting requested review from cipchk cipchk will be requested when the pull request is marked ready for review cipchk is a code owner

Assignees
No one assigned
Labels
PR: draft PR: target-major
Projects
None yet
Milestone
v19
2 participants
@Laffery @HyperLife1119