Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the config JSON to a YAML file #200

Open
swfarnsworth opened this issue Dec 12, 2020 · 3 comments
Open

Convert the config JSON to a YAML file #200

swfarnsworth opened this issue Dec 12, 2020 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@swfarnsworth
Copy link
Member

YAML files appear to be better suited for storing configuration data than JSON.

-Config file -- Should be converted to a YAML file.
-Config reader -- This should probably be deleted and we can let a library like PyYAML handle what this module is for.

@swfarnsworth swfarnsworth added enhancement New feature or request good first issue Good for newcomers labels Dec 12, 2020
@vmdhhh
Copy link

vmdhhh commented Dec 12, 2020

We can convert the JSON to YAML and just modify the Config reader to read YAML config rather than deleting it right?
What do you think @swfarnsworth ?

@swfarnsworth
Copy link
Member Author

@vmdhhh That's certainly an option, though the config reader that we implemented isn't widely used and if the PyYAML library does everything we'd need (and it's possible that it doesn't--I haven't done that exploration), I figure that in general we should reduce how much meta-functionality this package has.

@vmdhhh
Copy link

vmdhhh commented Dec 26, 2020

@swfarnsworth For now, AFAIK the Config reader module is only getting used in Pipeline components and Get Metamap .
So changing config JSON to YAML and including pyYAML into Pipeline components and Get Metamap would be enough right?
If yes, I can try to do it. Let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants