New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change fallback for digest algorithm in dnst key2ds from SHA-1 to SHA-256? #32

Open

mozzieongit opened this issue Nov 20, 2024 · 1 comment

Member

mozzieongit commented Nov 20, 2024 •

edited

Loading

Is using SHA-1 as the fallback a good idea? If new algorithms were to get introduced and we forget to update the above list, they would fallback to using SHA-1, right?

Originally posted by @mozzieongit in #2 (comment)

Regarding https://github.com/NLnetLabs/dnst/blob/main/src/commands/key2ds.rs#L224-L235

Contributor

tertsdiepraam commented Nov 20, 2024

Alternatively, we could remove the fallback altogether, asking the user to pick something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment