-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify obs used for FV3-JEDI and MPAS-JEDI tests #246
Comments
The PR for this issue is just about done. But one last thing I would like to do is unify the number of cores/tasks used for the FV3-JEDI and MPAS-JEDI ctests so that we can more accurately compare the runtime. For FV3-JEDI it seems like the cores need to match the layout settings for the model, so it would be easier to change the MPAS-JEDI settings. For MPAS-JEDI, we need a matching graphinfo file for the number of cores used to run JEDI. We have Does anyone know how to generate a |
@SamuelDegelia-NOAA I think @xyzemc had created those files for my case, who might also show you how to create those info files . Also, changing the mpi layout means you also need to change bump files. (that will be interesting to see if different mpi layout would produce identical results). |
Thank you @TingLei-NOAA for the reminder, I'll also regenerate the bumploc files. I agree that it will be interesting to see if that changes the results. |
Here is what I did before:
|
Thanks @xyzemc, that worked! I was also missing |
@TingLei-NOAA Here is the impact of changing the number of MPI tasks for our MPAS-JEDI EnVar test case. The bumploc files were regenerated for the plot with 160 tasks. There are some very very small differences so the results are not identical, but overall the impact is negligible. Also, the run with 160 tasks ran about 40 seconds faster. |
@SamuelDegelia-NOAA Thanks for sharing! Sure, it is difficult to produce identical results for procedures like bump (and mgbf). But good to know the differences are very small for bump. |
A couple of updates on this issue before the PR regarding unifying the localization radii between the GSI and JEDI test cases. I have disabled SDL/VDL in the GSI test case to better match the configurations we use in MPAS-JEDI and FV3-JEDI. To unify the localization radii between all test cases, I plan to use One problem here is that FV3-JEDI currently can only use sigma coordinates for its vertical localization (see discussion in #53). So for FV3-JEDI I just tuned the sigma radius to closely match the increment shape for a single obs test between between GSI. It seems that Here is a comparison of the vloc radii chosen for each experiment. Each increment profile goes to zero at around the same level. Edit: Here are the questions used for correlation length in GSI Var analysis (note that EnKF uses cutoff radii):
|
I think that GSI is not using e-folding scales, at least hloc/vloc are not
e-folding scales.
…______________________________
Ting Lei
Physical Scientist, Contractor with Lynker in support of
EMC/NCEP/NWS/NOAA
5830 University Research Ct., Cubicle 2765
College Park, MD 20740
***@***.***
301-683-3624
On Tue, Dec 17, 2024 at 1:59 PM Samuel Degelia ***@***.***> wrote:
A couple of updates on this issue before the PR regarding unifying the
localization radii between the GSI and JEDI test cases. I have disabled
SDL/VDL in the GSI test case to better match the configurations we use in
MPAS-JEDI and FV3-JEDI. To unify the localization radii between all test
cases, I plan to use hloc = 401 km and vloc = 1.095 log(p) for the JEDI
experiments (i.e., cutoff radii). For GSI, which uses e-folding radii,
these will be equivalent to hloc = 110 km and vloc = 0.30 log(p)
following #67 <#67>.
One problem here is that FV3-JEDI currently can only use sigma coordinates
for its vertical localization (see discussion in #53
<#53>). So for FV3-JEDI I just
tuned the sigma radius to closely match the increment shape for a single
obs test between between GSI. It seems that vloc = 0.75 sigma is very
close to vloc = 0.30 log(p) in GSI.
Here is a comparison of the vloc radii chosen for each experiment. Each
increment profile goes to zero at around the same level.
Screenshot.2024-12-17.135755.png (view on web)
<https://github.com/user-attachments/assets/f9340159-8fb6-4de2-bf30-9eb4f5aed6f9>
—
Reply to this email directly, view it on GitHub
<#246 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APEFS7BP6C5V4R6WSTK5LB32GBYBLAVCNFSM6AAAAABTBESYN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBZGM3DCMZQG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@TingLei-NOAA I am going off the discussion about e-folding and cutoff radius we had in #67. GSI uses these functions for localization:
Does that not mean the localization radius is set as e-folding radius? |
E-folding scale is 2*L in the above equation. But, I got your point. Your quoted definitions of GSI rf scales could be added to your original message. |
@TingLei-NOAA Great, thanks! I will update my original post. |
Yes, In GSI we have two parts, the GSI part and the EnKF part. The EnKF part uses the cutoff radius as @TingLei-NOAA mentioned. |
Description
The FV3-JEDI and MPAS-JEDI test cases in RDASApp now are valid at the same time. But it is still tricky to compare analyses and computational times between the two cases since their grid sizes are different. It would be helpful if both sets of tests used the same obs. A temporary workaround is to use obs from the offline domain check from FV3-JEDI since it is the smaller grid. That way no obs would be outside the domain for either set of tests.
This is a also good opportunity to also remove the confusing
obs_ctest
directory and just use the sameobs
directory for all purposes.Requirements
Use the same, offline domain check generated obs for both FV3-JEDI and MPAS-JEDI ctests and in the
expr
directory.Acceptance Criteria (Definition of Done)
Dependencies
#183 should be merged first. The
rrfs_bufr2ioda_msonet
ctest will compare against a IODA file in the unified obs directory which was generated using those updated bufr2ioda yamls. Sorrfs-test/testinput/rrfs_bufr2ioda_msonet.yaml
will also need to be updated with the corresponding changes from #183.The text was updated successfully, but these errors were encountered: