Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atmos data for first fhr not being produced when REPLAY_ICS is set to YES #2754

Closed
EricSinsky-NOAA opened this issue Jul 10, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@EricSinsky-NOAA
Copy link
Contributor

EricSinsky-NOAA commented Jul 10, 2024

What is wrong?

When REPLAY_ICS is set to YES, the f003 atmos master data is not generated in the forecast job. This causes the f003 atmos prod jobs to stall, resulting in missing f003 atmos prod data.

What should have happened?

f003 atmos master data should be generated in the forecast job. Then the f003 atmos prod task should be triggered and produce f003 atmos prod data.

What machines are impacted?

All or N/A

Steps to reproduce

  1. Set REPLAY_ICS to YES.
  2. Include atmosphere as one of the components.

Additional information

This was tested using GEFS. FHOUT_HF_GFS was set to 3 and FHOUT_GFS was set to 6.

Do you have a proposed solution?

To resolve this issue, the first lead time to be outputted must be ${OFFSET_START_HOUR}+(${DELTIM}/3600). For example, when REPLAY_ICS is set to YES, OFFSET_START_HOUR is set to 3, and DELTIM is 300, the first lead time for the atmos prod output should be approximately 3.0833. This fix was applied in the EP5r2 model runs. There is a feature branch with a fix to this issue and a PR will be submitted to global-workflow.

@EricSinsky-NOAA EricSinsky-NOAA added bug Something isn't working triage Issues that are triage labels Jul 10, 2024
@EricSinsky-NOAA EricSinsky-NOAA changed the title f003 atmos prod data not being produced when REPLAY_ICS is set to YES Atmos data for first fhr not being produced when REPLAY_ICS is set to YES Jul 10, 2024
@EricSinsky-NOAA
Copy link
Contributor Author

Update: This issue is being addressed in PR #2755.

@WalterKolczynski-NOAA WalterKolczynski-NOAA removed the triage Issues that are triage label Jul 22, 2024
WalterKolczynski-NOAA added a commit that referenced this issue Aug 13, 2024
This PR fixes a couple issues that arise when replay initial conditions
are used. These issues only occur when `REPLAY_ICS` is set to `YES` and
`OFFSET_START_HOUR` is greater than `0`. The following items are
addressed in this PR.

1. Fix issue that causes ocean_prod tasks not to be triggered (issue
[#2725](#2725)). A new
diag_table was added (called `diag_table_replay`) that is used only when
`REPLAY_ICS` is set to `YES`. This diag_table accounts for the offset
that occurs when using replay IC's.
2. Fix issue that causes atmos_prod tasks not to be triggered for the
first lead time (e.g. f003) (issue
[#2754](#2754)). When
`OFFSET_START_HOUR` is greater than `0`, the first `fhr` is
`${OFFSET_START_HOUR}+(${DELTIM}/3600)`, which is defined in
`forecast_predet.sh` and will allow data for the first lead time to be
generated. The filename with this lead time will still be labelled with
`OFFSET_START_HOUR`.
3. Minor modifications were made to the extractvars task so that atmos
data from replay cases can be processed.

This PR was split from PR #2680. 

Refs #2725, #2754 

---------

Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
@EricSinsky-NOAA
Copy link
Contributor Author

This issue has been resolved with the merging of PR #2755. Closing as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants