From ea20d5e1a79a8fb681ee366233f4b93f409ccda2 Mon Sep 17 00:00:00 2001 From: HenryWinterbottom-NOAA Date: Mon, 10 Jun 2024 15:35:12 +0000 Subject: [PATCH 1/5] Removing eroneous missing file messages. --- scripts/exglobal_diag.sh | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/scripts/exglobal_diag.sh b/scripts/exglobal_diag.sh index 2d48053bd2..134aea044a 100755 --- a/scripts/exglobal_diag.sh +++ b/scripts/exglobal_diag.sh @@ -233,8 +233,12 @@ EOFdiag rlist="conv_gps conv_ps conv_pw conv_q conv_sst conv_t conv_uv saphir" for rtype in $rlist; do set +e - ${CHGRP_CMD} *${rtype}* - ${STRICT_ON:-set -e} + for rfile in *"${rtype}"*; do + if [[ -s "${rfile}" ]]; then + ${CHGRP_CMD} "${rfile}" + ${STRICT_ON:-set -e} + fi + done done # If requested, create diagnostic file tarballs From 7fc3aa5fed5661dffabb116c7935a6e63a5b5850 Mon Sep 17 00:00:00 2001 From: "Henry R. Winterbottom" <49202169+HenryWinterbottom-NOAA@users.noreply.github.com> Date: Fri, 14 Jun 2024 12:40:32 -0600 Subject: [PATCH 2/5] Update scripts/exglobal_diag.sh Co-authored-by: David Huber <69919478+DavidHuber-NOAA@users.noreply.github.com> --- scripts/exglobal_diag.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/exglobal_diag.sh b/scripts/exglobal_diag.sh index 134aea044a..1602a6510a 100755 --- a/scripts/exglobal_diag.sh +++ b/scripts/exglobal_diag.sh @@ -234,9 +234,9 @@ EOFdiag for rtype in $rlist; do set +e for rfile in *"${rtype}"*; do - if [[ -s "${rfile}" ]]; then + if [[ -s "${rfile}" ]]; then ${CHGRP_CMD} "${rfile}" - ${STRICT_ON:-set -e} + ${STRICT_ON:-set -e} fi done done From 849559d980f09a19d15ae4e6db7e28aabe2c65c6 Mon Sep 17 00:00:00 2001 From: HenryWinterbottom-NOAA Date: Mon, 17 Jun 2024 22:04:31 +0000 Subject: [PATCH 3/5] Addressed reviewer comments. --- scripts/exglobal_diag.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/exglobal_diag.sh b/scripts/exglobal_diag.sh index 1602a6510a..4909250bda 100755 --- a/scripts/exglobal_diag.sh +++ b/scripts/exglobal_diag.sh @@ -236,7 +236,6 @@ EOFdiag for rfile in *"${rtype}"*; do if [[ -s "${rfile}" ]]; then ${CHGRP_CMD} "${rfile}" - ${STRICT_ON:-set -e} fi done done From bc1828f03943da315ce49e1577f2040774755b99 Mon Sep 17 00:00:00 2001 From: HenryWinterbottom-NOAA Date: Mon, 17 Jun 2024 22:06:51 +0000 Subject: [PATCH 4/5] Addressed reviewer comments. --- scripts/exglobal_diag.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/exglobal_diag.sh b/scripts/exglobal_diag.sh index 4909250bda..6fa19f1149 100755 --- a/scripts/exglobal_diag.sh +++ b/scripts/exglobal_diag.sh @@ -232,11 +232,11 @@ EOFdiag # Restrict diagnostic files containing rstprod data rlist="conv_gps conv_ps conv_pw conv_q conv_sst conv_t conv_uv saphir" for rtype in $rlist; do - set +e for rfile in *"${rtype}"*; do if [[ -s "${rfile}" ]]; then ${CHGRP_CMD} "${rfile}" fi + ${STRICT_ON:-set -e} done done From 5345eb150f07eeba61d826be7b106808e395d1ba Mon Sep 17 00:00:00 2001 From: HenryWinterbottom-NOAA Date: Mon, 17 Jun 2024 22:38:11 +0000 Subject: [PATCH 5/5] Addressed reviewer comments. --- scripts/exglobal_diag.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/exglobal_diag.sh b/scripts/exglobal_diag.sh index 6fa19f1149..e1faa7b2ee 100755 --- a/scripts/exglobal_diag.sh +++ b/scripts/exglobal_diag.sh @@ -236,7 +236,6 @@ EOFdiag if [[ -s "${rfile}" ]]; then ${CHGRP_CMD} "${rfile}" fi - ${STRICT_ON:-set -e} done done