Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed remaining issues from PR #15 for satwnd. #18

Open
emilyhcliu opened this issue Jan 15, 2025 · 0 comments
Open

Fixed remaining issues from PR #15 for satwnd. #18

emilyhcliu opened this issue Jan 15, 2025 · 0 comments

Comments

@emilyhcliu
Copy link
Collaborator

  • unit for obsType
  • python function naming conventions (_get_QualityInformation_and_GeneratingApplication)
  • category definition: "h8" vs. ["h8"]

#15 (review)
#15 (comment)
#15 (comment)
#15 (comment)
#15 (comment)
#15 (comment)
#15 (comment)
#15 (comment)
#15 (comment)
#15 (comment)
#15 (comment)
#15 (comment)
@emilyhcliu emilyhcliu mentioned this issue Jan 16, 2025
Merged
emilyhcliu added a commit that referenced this issue Jan 16, 2025
@emilyhcliu
Some minors fixes for satwind (#20)
0d008bd 
Some minor fixes for satwind:
- change the Python function name to be Pep 8 naming convention
compliant

Resolve[ issue #18](#18)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emilyhcliu