Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency in OBC variable naming convetions #123

Open
theresa-morrison opened this issue Dec 6, 2024 · 6 comments
Open

Consistency in OBC variable naming convetions #123

theresa-morrison opened this issue Dec 6, 2024 · 6 comments
Assignees

Comments

@theresa-morrison
Copy link
Contributor

I am using the boundary tools to generate OBC's for the Arctic domain from GLORYS. The options in the config file are great, but there is a difference in the naming convention for OBC's in the Arctic and other domains. For example, the temperature OBC's in the Arctic are temp_001 but the current scripts make thetao_001. These naming conventions also extend to the variables in the OBC files. It looks likewrite_glorys_boundary.py uses the GLORYS names for the files.

I think we could add a output name option in the config file, or we could convert the Arctic OBC's and xmls to use the names already in write_glorys_boundary.py. This issue is not urgent, but I think we should consider this to improve the consistency of our experiments across regions.

@theresa-morrison
Copy link
Contributor Author

@kshedstrom

@kshedstrom
Copy link

@theresa-morrison It is probably a good idea to rename all the Arctic OBCs to match the rest.

@yichengt900
Copy link
Contributor

@theresa-morrison, thank you for opening this issue. I agree that it’s probably better to rename all the Arctic OBCs to match the others. Of course, we could still add a rename option in the BC generation script. @uwagura, could you take a look at write_glorys_boundary.py when you get a chance?

@uwagura
Copy link
Collaborator

uwagura commented Dec 9, 2024

Just opened up a PR addressing this. Do we want to add custom name options to the other scripts in this folder, or is it fine if we only have options for write_glorys_boundary.py @yichengt900 ?

@theresa-morrison
Copy link
Contributor Author

Thanks for the changes with #124

@theresa-morrison
Copy link
Contributor Author

theresa-morrison commented Dec 11, 2024

I think we should leave this issue open as a reminder to change the names of the Arctic OBCs once files with the GLORYS naming convention are available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants