Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

let fre cmor run process tripolar ocean data #303

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

let fre cmor run process tripolar ocean data #303

wants to merge 7 commits into from

Conversation

ilaflott
Copy link
Member

this PR will ideally enable fre cmor run to process ocean data on a native tripolar grid. also will do some general clean up here and there. relevant background: #268 PCMDI/cmor#766 and PCMDI/cmor#767

Describe your changes

  • remove GitPython pip-only dependency that can only be fulfilled by terrible habits
  • add PCMDI/cmip6-cmor-tables as submodule dependency
  • set minimum python version to 3.10 minimum
  • ... more to come ... work-in-progress ...

Issue ticket number and link (if applicable)

will close #298 (ideally)

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback

@ilaflott
add in cmip6-cmor-tables as a submodule, remove un-maintained gitpyth…
6dce8ef 
…on pip-only dependency... nasty tech debt i should get rid of before its too late!
@ilaflott ilaflott added bug Something isn't working new functioning New feature or request tricky Likely to encounter significant friction to solution priority: HIGH labels Dec 24, 2024
@ilaflott ilaflott self-assigned this Dec 24, 2024
@ilaflott ilaflott linked an issue Dec 24, 2024 that may be closed by this pull request
CMORmeal: successfully process ocean variables on tripolar grid with cmor #298
Open
7 tasks
@ilaflott
Copy link
Member Author

so asking conda/mamba to use python3.10 or greater is surprisingly an issue. Dinking around with this locally, the first thing it complains about is cylc-uiserver. Given that this has yet-to-be-utilized in the actual repository, I comment it out.

The next issue is catalogbuilder... actually, really, a requirement of catalogbuilder's. intake-esm==2023.7.7, which seems to desire a python of 3.9 or less, but 3.9 is nearing EOL.

Given that this quick python version bump was supposed to be a quick-sidequest, i'll be restoring the dependencies and barking up that tree some other time.

@ilaflott
restore deps with the exception of the pip-installed gitpython and le…
ff8d8ce 
…aving cmor>=3.9.0 because i know we should not bother with anything less than 3.9.0 for cmor
@ilaflott
syntax error
32abb9b
@ilaflott
Copy link
Member Author

ilaflott commented Dec 24, 2024 •
edited
Loading

every now and then, a random conda build fails... here, it claims import git is causing the failure. I did remove that module, but i also removed that line

edit: same failure, same job. sanity demanding i ignore the conda_build workflow for a minute apparently

edit2: same failure, different job. xmas nightmare! moving on...

@ilaflott
whitespace-cleanup some files for lint complaints, poke the test file…
ac61693 
… with the zombie-problem in the github-repos conda build ci workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ilaflott ilaflott

Labels
bug Something isn't working new functioning New feature or request priority: HIGH tricky Likely to encounter significant friction to solution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMORmeal: successfully process ocean variables on tripolar grid with cmor
1 participant
@ilaflott