[FEAT] WEEK6 - xml 필수과제 #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeeyubin
approved these changes
May 27, 2024
Comment on lines
+11
to
+15
|
|
||
| class LoginViewModel : ViewModel() { | ||
| private val authService by lazy { ServicePool.authService } | ||
| private val _loginStateLiveData = MutableLiveData<LoginState>() | ||
|
|
Comment on lines
+17
to
+23
| viewModelScope.launch { | ||
| try { | ||
| val response = authService.login(request) | ||
| _loginStateLiveData.value = LoginState(true, "로그인 성공") | ||
|
|
||
| } catch (e: HttpException) { | ||
| _loginStateLiveData.value = LoginState(false, "로그인 실패 ${e.code()}") |
There was a problem hiding this comment.
세미나에서 runCathcing에 대해서 배웠으니까 활용해보면 좋을 것 같네요!
Comment on lines
+17
to
+18
| setContentView(binding.root) | ||
| SignupButtonClickListener() |
There was a problem hiding this comment.
Suggested change
| setContentView(binding.root) | |
| SignupButtonClickListener() | |
| setContentView(binding.root) | |
| signupButtonClickListener() |
사소한 디테일!
Comment on lines
+41
to
+52
| private fun getSignUpRequestDto(): RequestSignUpDto { | ||
| val id = binding.edtSignupId.text.toString() | ||
| val password = binding.edtSignupPassword.text.toString() | ||
| val nickname = binding.edtSignupNickname.text.toString() | ||
| val phoneNumber = binding.edtSignupPhonenumber.text.toString() | ||
| return RequestSignUpDto( | ||
| authenticationId = id, | ||
| password = password, | ||
| nickname = nickname, | ||
| phone = phoneNumber | ||
| ) | ||
| } |
There was a problem hiding this comment.
Suggested change
| private fun getSignUpRequestDto(): RequestSignUpDto { | |
| val id = binding.edtSignupId.text.toString() | |
| val password = binding.edtSignupPassword.text.toString() | |
| val nickname = binding.edtSignupNickname.text.toString() | |
| val phoneNumber = binding.edtSignupPhonenumber.text.toString() | |
| return RequestSignUpDto( | |
| authenticationId = id, | |
| password = password, | |
| nickname = nickname, | |
| phone = phoneNumber | |
| ) | |
| } | |
| private fun getSignUpRequestDto(): RequestSignUpDto = | |
| with(binding) { | |
| RequestSignUpDto( | |
| authenticationId = edtSignupId.text.toString(), | |
| password = edtSignupPassword.text.toString(), | |
| nickname = edtSignupNickname.text.toString(), | |
| phone = edtSignupPhonenumber.text.toString() | |
| ) | |
| } |
이렇게 바꿔줄 수 도 있을 것 같아요!
Comment on lines
+12
to
+13
| private val authService by lazy { ServicePool.authService } | ||
| val liveData = MutableLiveData<SignUpState>() |
Comment on lines
57
to
+58
| android:layout_marginStart="70dp" | ||
| android:layout_marginTop="300dp" |
There was a problem hiding this comment.
허거덩 너무 큰 dp 값은 지양해주시면 감사하겠습니당
Comment on lines
+42
to
+44
| companion object { | ||
| var memberId = "1" | ||
| } |
There was a problem hiding this comment.
Suggested change
| companion object { | |
| var memberId = "1" | |
| } | |
| companion object { | |
| const val MEMBER_ID = "1" | |
| } |
상수화하려면 const val로 바꿔줘야 할 것 같아요! 그리고 저는 보통 변하지 않는 값을 강조하기 위해 대문자로 표시해줍니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
시연 영상은 달라진 바가 없습니다 !
https://github.com/NOW-SOPT-ANDROID/nakyung-lee/assets/109855280/8ad91db6-1027-4aa4-992d-7b8780476f26
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
명예 OB분께서 너무 꼼꼼히 잘 봐주신 덕에 폴더 구조와 컨벤션 등등이 아주 아주 깔끔해졌습니다 !!
제가 일일이 댓글을 달면 알림이 갈까봐 . . 하트만 몇 개 눌렀는데요 .. 정말 감사합니다 많이 배웠습니다 !!