Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect precursor m/z when loading MGF file from GNPS #282

Open
liannette opened this issue Nov 5, 2024 · 3 comments · May be fixed by #283
Open

Incorrect precursor m/z when loading MGF file from GNPS #282

liannette opened this issue Nov 5, 2024 · 3 comments · May be fixed by #283
Assignees

Comments

@liannette
Copy link

When loading the MGF file into Spectrum object, the m/z of the precursor ion is imported/calculated incorrectly.

In the MGF file, the "pepmass" of a spectrum/feature is given. Currently, this pepmass is divided by the ion charge to calculate the precursor m/z.

However, this step is unnecessary. The pepmass value is equivalent to the precursor m/z value, they are just two different terms for the same thing - the m/z of the ion selected for fragmentation.

@liannette
Copy link
Author

@CunliangGeng I don't think that I can assign this issue to myself, can you do it?

@justinjjvanderhooft
Copy link

@liannette I did it....

@liannette liannette linked a pull request Nov 5, 2024 that will close this issue
@CunliangGeng
Copy link
Member

However, this step is unnecessary. The pepmass value is equivalent to the precursor m/z value, they are just two different terms for the same thing - the m/z of the ion selected for fragmentation.

From the https://www.matrixscience.com/help/data_file_help.html#GEN, what I got is that PEPMASS is peptide mass but not m/z. They may have same values but we should treat them separately in the code. Are you sure we should use pepmass for m/z? If so, you have to give your comments in the code to make it clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

3 participants