Precursor m/z value fix #283
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liannette
commented
Nov 5, 2024
| f"Assuming charge is 1 for spectrum '{self._file}'." | ||
| ) | ||
| charge = 1 | ||
| return charge |
There was a problem hiding this comment.
I assume this method was necessary because the precursor charge was used as divisor and it is not possible to divide by 0.
In any case, the charge is expected to never be 0, but if that's the value in the MGF file, I think it should be kept.
|
@CunliangGeng I would like to add you as reviewer |
|
@liannette I just did (Cunliang is on holidays till next week Wednesday) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #282
Major changes: