Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Egregious Code Duplication in PowerFlows #43

Closed
GabrielKS opened this issue Jul 22, 2024 · 2 comments
Closed

Egregious Code Duplication in PowerFlows #43

GabrielKS opened this issue Jul 22, 2024 · 2 comments

Comments

@GabrielKS
Copy link
Contributor

The block:

    for (bus_no, ix) in bus_lookup
        bus_name = temp_bus_map[bus_no]
        bus = PSY.get_component(PSY.Bus, sys, bus_name)
        bus_type[ix] = PSY.get_bustype(bus)
        if bus_type[ix] == PSY.ACBusTypes.REF
            bus_angles[ix] = 0.0
        else
            bus_angles[ix] = PSY.get_angle(bus)
        end
        bus_magnitude[ix] = PSY.get_magnitude(bus)
    end

appears four times in PowerFlowData.jl. I'm sure there is more of this.

@jd-lara
Copy link
Member

jd-lara commented Aug 6, 2024

This might have been me.

@rodrigomha
Copy link
Collaborator

Closed via #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants