Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jd/fixes area balancing models #1130

Merged
merged 34 commits into from
Sep 9, 2024
Merged

Jd/fixes area balancing models #1130

merged 34 commits into from
Sep 9, 2024

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Jul 29, 2024

closes #1107

@jd-lara jd-lara requested a review from rodrigomha July 29, 2024 19:45
@jd-lara jd-lara self-assigned this Jul 29, 2024
Copy link
Contributor

github-actions bot commented Jul 29, 2024

Performance Results

Version Precompile Time
Main 3.209087648
This Branch 3.369946315
Version Build Time
Main-Build Time Precompile 51.106315366
Main-Build Time Postcompile 1.194522667
This Branch-Build Time Precompile 51.243373091
This Branch-Build Time Postcompile 1.218833678
Version Build Time
Main-Solve Time Precompile 1661.691636165
Main-Solve Time Postcompile 1640.550410694
This Branch-Solve Time Precompile 525.887757141
This Branch-Solve Time Postcompile 494.254999986

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 70.06369% with 47 lines in your changes missing coverage. Please review.

Project coverage is 77.89%. Comparing base (b405b10) to head (53fc090).
Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
...s_models/device_constructors/branch_constructor.jl 69.23% 16 Missing ⚠️
...ices/common/objective_function/piecewise_linear.jl 0.00% 14 Missing ⚠️
src/devices_models/devices/area_interchange.jl 66.66% 6 Missing ⚠️
src/parameters/update_parameters.jl 42.85% 4 Missing ⚠️
src/core/parameters.jl 40.00% 3 Missing ⚠️
...vice_constructors/thermalgeneration_constructor.jl 96.55% 1 Missing ⚠️
src/devices_models/devices/AC_branches.jl 66.66% 1 Missing ⚠️
src/feedforward/feedforward_arguments.jl 50.00% 1 Missing ⚠️
.../simulation/initial_condition_update_simulation.jl 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1130      +/-   ##
==========================================
+ Coverage   77.44%   77.89%   +0.45%     
==========================================
  Files         118      118              
  Lines       12658    12700      +42     
==========================================
+ Hits         9803     9893      +90     
+ Misses       2855     2807      -48     
Flag Coverage Δ
unittests 77.89% <70.06%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ce_constructors/renewablegeneration_constructor.jl 92.72% <100.00%> (ø)
...devices_models/devices/common/add_to_expression.jl 78.03% <ø> (ø)
src/devices_models/devices/electric_loads.jl 95.45% <100.00%> (ø)
src/feedforward/feedforward_constraints.jl 73.48% <ø> (+11.39%) ⬆️
src/initial_conditions/initialization.jl 96.72% <100.00%> (+0.05%) ⬆️
src/operation/time_series_interface.jl 63.63% <ø> (ø)
src/parameters/add_parameters.jl 65.65% <100.00%> (+0.35%) ⬆️
src/services_models/services_constructor.jl 97.60% <100.00%> (+13.90%) ⬆️
...vice_constructors/thermalgeneration_constructor.jl 98.30% <96.55%> (-0.01%) ⬇️
src/devices_models/devices/AC_branches.jl 81.20% <66.66%> (+0.13%) ⬆️
... and 7 more

... and 3 files with indirect coverage changes

@jd-lara jd-lara marked this pull request as ready for review August 20, 2024 21:18
Copy link
Contributor

@rodrigomha rodrigomha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. We may need to QA/QC the DCP/PTDF models for AreaInterchange.

Besides the testing, this should be fine for generalizing

@rodrigomha
Copy link
Contributor

It also:
Closes #1100
Closes #1103
Closes #1134
Closes #1135
via #1136

@jd-lara jd-lara requested a review from rodrigomha September 9, 2024 19:17
@jd-lara jd-lara merged commit f7e83f4 into main Sep 9, 2024
9 checks passed
@jd-lara jd-lara deleted the jd/fixes_area_balancing_models branch September 11, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement slack variables in the UpperBoundFeedforward constraints
2 participants