Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile errors in 5.5.0 when PX_SUPPORT_GPU_PHYSX is False #347

Open
kermado opened this issue Dec 25, 2024 · 1 comment
Open

Compile errors in 5.5.0 when PX_SUPPORT_GPU_PHYSX is False #347

kermado opened this issue Dec 25, 2024 · 1 comment

Comments

@kermado
Copy link

kermado commented Dec 25, 2024

Library and Version

PhysX v5.5.0

Operating System

Windows 10

Steps to Trigger Behavior

  1. Disable GPU support by defining PX_SUPPORT_GPU_PHYSX to False
  2. Build as usual
  3. Observe compile errors

Details

It looks like there are a few issues:

  1. In DyIslandManager.h, the following lines need to be enclosed with "#if PX_SUPPORT_GPU_PHYSX":
template <> struct IGNodeTraits<Dy::DeformableSurface>			{ enum { TypeID = IG::Node::eDEFORMABLE_SURFACE_TYPE };	};
template <> struct IGNodeTraits<Dy::DeformableVolume>			{ enum { TypeID = IG::Node::eDEFORMABLE_VOLUME_TYPE };	};
template <> struct IGNodeTraits<Dy::ParticleSystem>				{ enum { TypeID = IG::Node::ePARTICLESYSTEM_TYPE };		};
  1. In NpPhysics.cpp, the createDeformableSurfaceMaterial() function stub is missing two arguments.

  2. In NpPhysics.cpp, there are redefinitions of createDeformableSurfaceMaterial(), getNbDeformableSurfaceMaterials() and getDeformableSurfaceMaterials().

@teub
Copy link

teub commented Dec 26, 2024

I came here to open that issue, thanks. This release is so broken, it looks like physx could benefit from some sort of CI/CD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants