Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Enable non-gelu activations for BERT LM Head #918

Open
skothenhill-nv opened this issue Jul 9, 2024 · 1 comment
Open
Labels
stale No activity in 60 days on issue or PR

Comments

@skothenhill-nv
Copy link

skothenhill-nv commented Jul 9, 2024

Is your feature request related to a problem? Please describe.
Bert LM-Head hardcode's gelu as the activation, this has caused problems in downstream projects (e.g. NeMo).

Describe the solution you'd like
Rather than hardcoding nn.gelu, we accept the field set to TransformerConfig.activation_func as done for other models.

Describe alternatives you've considered
did not consider alternatives

Proposed implementation
PR.

Additional context
Spoke with @shanmugamr1992 and used his suggested solution.

Copy link

github-actions bot commented Sep 8, 2024

Marking as stale. No activity in 60 days.

@github-actions github-actions bot added the stale No activity in 60 days on issue or PR label Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale No activity in 60 days on issue or PR
Projects
None yet
Development

No branches or pull requests

1 participant